[PR #89] [MERGED] feat: add ability to manage rule groups #87

New issue

Closed

opened 2026-02-27 23:18:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:18:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/89
Author: @mamullen13316
Created: 12/13/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @mamullen13316

Base: main ← Head: firewall_rule_group

📝 Commits (2)

b12585a feat: add ability to manage rule groups
e966ae7 fix: remove unused argument

📊 Changes

5 files changed (+496 additions, -115 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/firewallapi.py (+226 -114)
➕ sophosfirewall_python/firewallrulegroup.py (+203 -0)
➕ sophosfirewall_python/templates/createfwrulegroup.j2 (+32 -0)
➕ sophosfirewall_python/templates/updatefwrulegroup.j2 (+34 -0)

📄 Description

adds get_rulegroup, create_rulegroup() and update_rulegroup() methods

It is not currently possible to delete a rule from a rulegroup using the API. This is done using the Detach menu option in the GUI. Due to this, it is only possible to add rules to a rulegroup using the update_rulegroup() method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/89 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 12/13/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `firewall_rule_group` --- ### 📝 Commits (2) - [`b12585a`](https://github.com/sophos/sophos-firewall-sdk/commit/b12585a112f0c18b8abdbf2228960ce397adebb6) feat: add ability to manage rule groups - [`e966ae7`](https://github.com/sophos/sophos-firewall-sdk/commit/e966ae7c328fa0a152d3772d42ea1d74f7fb21ee) fix: remove unused argument ### 📊 Changes **5 files changed** (+496 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/firewallapi.py` (+226 -114) ➕ `sophosfirewall_python/firewallrulegroup.py` (+203 -0) ➕ `sophosfirewall_python/templates/createfwrulegroup.j2` (+32 -0) ➕ `sophosfirewall_python/templates/updatefwrulegroup.j2` (+34 -0) </details> ### 📄 Description - adds `get_rulegroup`, `create_rulegroup()` and `update_rulegroup()` methods > It is not currently possible to delete a rule from a rulegroup using the API. This is done using the Detach menu option in the GUI. Due to this, it is only possible to add rules to a rulegroup using the `update_rulegroup()` method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 23:18:59 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/sophos-firewall-sdk#87

No description provided.

Rows
Columns