[PR #75] [MERGED] Fix: update_acl_rule() fixes #76

Closed
opened 2026-02-27 23:18:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/75
Author: @mamullen13316
Created: 8/9/2024
Status: Merged
Merged: 8/9/2024
Merged by: @mamullen13316

Base: mainHead: fix_acl_rule


📝 Commits (3)

  • a60fd13 fix: allow for empty service_list argument
  • cf7c8ad fix: include existing lists when unspecified
  • 82a0c59 version: update to v0.1.46

📊 Changes

3 files changed (+6 additions, -4 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/admin.py (+3 -3)
📝 sophosfirewall_python/templates/updateserviceacl.j2 (+2 -0)

📄 Description

Fixed issue where existing lists are not inserted into payload when they are omitted from input arguments.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/75 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 8/9/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `fix_acl_rule` --- ### 📝 Commits (3) - [`a60fd13`](https://github.com/sophos/sophos-firewall-sdk/commit/a60fd130aba441ae265df81a4830bbee9783518e) fix: allow for empty service_list argument - [`cf7c8ad`](https://github.com/sophos/sophos-firewall-sdk/commit/cf7c8addfedf8e810318fa77b9a40b444d662d8b) fix: include existing lists when unspecified - [`82a0c59`](https://github.com/sophos/sophos-firewall-sdk/commit/82a0c59274406058e9f3d013fe9d911bbade2801) version: update to v0.1.46 ### 📊 Changes **3 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/admin.py` (+3 -3) 📝 `sophosfirewall_python/templates/updateserviceacl.j2` (+2 -0) </details> ### 📄 Description Fixed issue where existing lists are not inserted into payload when they are omitted from input arguments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:18:57 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sophos-firewall-sdk#76
No description provided.