[PR #76] [MERGED] fix: update_acl_rule() module overwriting action from drop to accept #75

New issue

Closed

opened 2026-02-27 23:18:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:18:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/76
Author: @mamullen13316
Created: 8/9/2024
Status: ✅ Merged
Merged: 8/9/2024
Merged by: @mamullen13316

Base: main ← Head: fix_acl_rule

📝 Commits (2)

19dcce7 fix: missing action for replace update
ffbc223 version: update to v0.1.47

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/admin.py (+3 -1)

📄 Description

fixed issue where update_acl_rule() was overwriting the action field from drop to accept. Omitting the action field from the update was causing the default of accept to be used.
updated version to v0.1.47

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/76 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 8/9/2024 **Status:** ✅ Merged **Merged:** 8/9/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `fix_acl_rule` --- ### 📝 Commits (2) - [`19dcce7`](https://github.com/sophos/sophos-firewall-sdk/commit/19dcce724ba2d74947403f6d8b84ff41c4a70798) fix: missing action for replace update - [`ffbc223`](https://github.com/sophos/sophos-firewall-sdk/commit/ffbc2233d6836abffd970db155e84e76fb953bd1) version: update to v0.1.47 ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/admin.py` (+3 -1) </details> ### 📄 Description - fixed issue where update_acl_rule() was overwriting the action field from drop to accept. Omitting the action field from the update was causing the default of accept to be used. - updated version to v0.1.47 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>