[PR #533] [CLOSED] [FBref] Optimize reading team match history by creating and reading from csv cache #635

Closed
opened 2026-03-02 15:58:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/533
Author: @Kalaweksh
Created: 4/4/2024
Status: Closed

Base: masterHead: master


📝 Commits (3)

  • 2d43c88 [FBref] Optimize reading team match history
  • 4b43404 [FBref] Clean up read_team_match_stats
  • 690abb6 Merge branch 'probberechts:master' into master

📊 Changes

1 file changed (+145 additions, -7 deletions)

View changed files

📝 soccerdata/fbref.py (+145 -7)

📄 Description

Resolves

Changes

  • Modified read_team_match_stats to cache match history tables as csv files for faster reading.

  • Added force_cache parameter to read_team_match_stats for consistency with other methods.

Issues

  • Currently does not detect if league seasons in the cache are not complete e.g la liga season 20-21 only cached up to matchweek 24. This can result in the silent returning of tables with missing data to the user in certain edge cases.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/533 **Author:** [@Kalaweksh](https://github.com/Kalaweksh) **Created:** 4/4/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`2d43c88`](https://github.com/probberechts/soccerdata/commit/2d43c885f8e6ed1ef7e8515d773353a1ccefa327) [FBref] Optimize reading team match history - [`4b43404`](https://github.com/probberechts/soccerdata/commit/4b43404b92dd1e89ddac59dfc23706a923902030) [FBref] Clean up read_team_match_stats - [`690abb6`](https://github.com/probberechts/soccerdata/commit/690abb60668a576d2f3a14ed5acc3f14bf4e3adb) Merge branch 'probberechts:master' into master ### 📊 Changes **1 file changed** (+145 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+145 -7) </details> ### 📄 Description ### Resolves - #458 ### Changes - Modified read_team_match_stats to cache match history tables as csv files for faster reading. - Added force_cache parameter to read_team_match_stats for consistency with other methods. ### Issues - Currently does not detect if league seasons in the cache are not complete e.g la liga season 20-21 only cached up to matchweek 24. This can result in the silent returning of tables with missing data to the user in certain edge cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 15:58:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#635
No description provided.