mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-26 02:25:51 +03:00
[PR #412] [MERGED] Handle Selenium 4.13 no longer supporting headless #533
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#533
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/412
Author: @probberechts
Created: 10/14/2023
Status: ✅ Merged
Merged: 10/14/2023
Merged by: @probberechts
Base:
master← Head:fix/selenium-headless📝 Commits (1)
1593c74Handle Selenium 4.13 no longer supporting headless📊 Changes
2 files changed (+12 additions, -1 deletions)
View changed files
📝
soccerdata/_common.py(+11 -0)📝
soccerdata/whoscored.py(+1 -1)📄 Description
Selenium does no longer support headless mode for version 4.13 and above. This was added to the docs and a warning is raised if headless mode is enabled for a recent version of Selenium.
Also adds a temporary fix for undetected-chromedriver, setting "headless" explicitly to False, such that soccerdata can still be used with recent versions of selenium.
Fixes #398
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.