[GH-ISSUE #150] Remove flake8-plugins from normal dependencies #33

New issue

Closed

opened 2026-03-02 15:55:12 +03:00 by kerem · 3 comments

kerem commented

2026-03-02 15:55:12 +03:00

Owner

Originally created by @jerem1e on GitHub (Jan 21, 2023).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/150

These dependencies are currently stored in [tool.poetry.dependencies] and [tool.poetry.dev-dependencies]:

flake8-docstrings = "^1.6.0"
flake8-rst-docstrings = "^0.3.0"

They are only needed for development, so they should not be in [tool.poetry.dependencies].

Originally created by @jerem1e on GitHub (Jan 21, 2023). Original GitHub issue: https://github.com/probberechts/soccerdata/issues/150 These dependencies are currently stored in `[tool.poetry.dependencies]` and `[tool.poetry.dev-dependencies]`: ``` flake8-docstrings = "^1.6.0" flake8-rst-docstrings = "^0.3.0" ``` They are only needed for development, so they should not be in `[tool.poetry.dependencies]`.

kerem closed this issue

2026-03-02 15:55:12 +03:00

kerem commented

2026-03-02 15:55:13 +03:00

Author

Owner

@probberechts commented on GitHub (Jan 21, 2023):

Good catch! Thanks.

@probberechts commented on GitHub (Jan 21, 2023): Good catch! Thanks.

kerem commented

2026-03-02 15:55:13 +03:00

Author

Owner

@jerem1e commented on GitHub (Jan 21, 2023):

Thanks for the quick fix, but
after pulling the changes, I get this error when installing:

Because soccerdata depends on flake8 (^6.0.0) which doesn't match any versions, version solving failed.

After deleting the poetry.lock file, it was fine so, you might need to delete the poetry.lock file (and reinstall it).

@jerem1e commented on GitHub (Jan 21, 2023): Thanks for the quick fix, but after pulling the changes, I get this error when installing: ``` Because soccerdata depends on flake8 (^6.0.0) which doesn't match any versions, version solving failed. ``` After deleting the `poetry.lock` file, it was fine so, you might need to delete the `poetry.lock` file (and reinstall it).

kerem commented

2026-03-02 15:55:13 +03:00

Author

Owner

@probberechts commented on GitHub (Jan 21, 2023):

Indeed. I did not think about that. It should be resolved with f8ad944.

@probberechts commented on GitHub (Jan 21, 2023): Indeed. I did not think about that. It should be resolved with [f8ad944](https://github.com/probberechts/soccerdata/commit/f8ad944a4efe35a07fdb7f52d8b9e7dfe8d6ffe2).

kerem referenced this issue

2026-03-02 15:56:58 +03:00

[PR #33] [MERGED] Update actions/cache action to v3.0.2 #232