mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-26 02:25:51 +03:00
[GH-ISSUE #704] Incorrect match schedule for 2023-24 Season #150
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#150
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lowkenji-464 on GitHub (Sep 13, 2024).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/704
Describe the bug
fbref = sd.FBref(leagues="ENG-Premier League", seasons=[23])
The data cached in the above function does not return the correct data when used with (fbref.read_season() or fbref.read_schedule()) and consequently returns the incorrect match level data for functions like .read_shot_events() functions (currently for '2023-24' season it returns data from '2024-2025' season.
Believe this is due to an incorrect URL being linked to the season (can be repro using .read_seasons() function) i.e.
Incorrect URL (current): /en/comps/9/Premier-League-Stats
Correct/Proposed URL: en/comps/9/2023-2024/2023-2024-Premier-League-Stats
Affected scrapers
This affects the following scrapers:
Code example
N/A
Error message
Additional context
Add any other context about the problem here.
Contributor Action Plan
@probberechts commented on GitHub (Oct 10, 2024):
I think the solution might simply be to use
no_cache=Trueonce to update the URL's. I know it's tricky, but FBref updates the URL's each season.