starred/smtprelay

Fork 0

mirror of https://github.com/decke/smtprelay.git synced 2026-04-25 04:45:52 +03:00

[GH-ISSUE #62] Add metrics exposition #13

New issue

Closed

opened 2026-02-26 18:32:57 +03:00 by kerem · 4 comments

kerem commented

2026-02-26 18:32:57 +03:00

Owner

Originally created by @pomverte on GitHub (Feb 25, 2022).
Original GitHub issue: https://github.com/decke/smtprelay/issues/62

Hello,

Do you have any plan to support metrics expostion in openmetrics format ?

Are you open to contribution ?

That would allow monitoring services like Prometheus to scrape metrics

Reference : https://prometheus.io/docs/guides/go-application/

Originally created by @pomverte on GitHub (Feb 25, 2022). Original GitHub issue: https://github.com/decke/smtprelay/issues/62 Hello, Do you have any plan to support metrics expostion in openmetrics format ? Are you open to contribution ? That would allow monitoring services like Prometheus to scrape metrics Reference : https://prometheus.io/docs/guides/go-application/

kerem closed this issue

2026-02-26 18:32:57 +03:00

kerem commented

2026-02-26 18:32:58 +03:00

Author

Owner

@JonathonReinhart commented on GitHub (Feb 25, 2022):

@grafana has a fork where they added metrics for prometheus: https://github.com/grafana/smtprelay/pull/9/. They attempted to upstream all of their changes in #13, but it wasn't organized in a way we were willing to accept. In this comment I explained how I fixed up most of their work into individual PRs, but the Prometheus exporter was not included.

I'll let @decke confirm that he is willing to accept this feature. You may want to look at https://github.com/grafana/smtprelay/pull/9/ to avoid unnecessary work, and increase coherency within the network of forks.

cc @electron0zero @dannykopping

@JonathonReinhart commented on GitHub (Feb 25, 2022): @grafana has [a fork](https://github.com/grafana/smtprelay) where they added metrics for prometheus: https://github.com/grafana/smtprelay/pull/9/. They attempted to upstream all of their changes in #13, but it wasn't organized in a way we were willing to accept. In [this comment](https://github.com/decke/smtprelay/pull/13#issuecomment-797957014) I explained how I fixed up most of their work into individual PRs, but the Prometheus exporter was not included. I'll let @decke confirm that he is willing to accept this feature. You may want to look at https://github.com/grafana/smtprelay/pull/9/ to avoid unnecessary work, and increase coherency within the network of forks. cc @electron0zero @dannykopping

kerem commented

2026-02-26 18:32:58 +03:00

Author

Owner

@decke commented on GitHub (Feb 26, 2022):

It's fine for me but since I don't use prometheus myself I likely won't notice if we break it one day.

@decke commented on GitHub (Feb 26, 2022): It's fine for me but since I don't use prometheus myself I likely won't notice if we break it one day.

kerem commented

2026-02-26 18:32:58 +03:00

Author

Owner

@pomverte commented on GitHub (Feb 26, 2022):

Thank you for the answers !

Given that it's not your use case and this has already been done in grafana/smtprelay, I will take a look at thee fork and see if it suits my needs

I have another question concerning the project, does it support retry ?

I'm trying to evaluate if smtprelay can be setup between my service and another SMTP server (why ? It's not available as much as I'd like)


 ┌─────────┐      ┌───────────┐      ┌─────────────┐
 │ service ├─────►│ smtprelay ├──x──►│ smtp server │
 └─────────┘      └───────────┘      └─────────────┘

@pomverte commented on GitHub (Feb 26, 2022): Thank you for the answers ! Given that it's not your use case and this has already been done in [grafana/smtprelay](https://github.com/grafana/smtprelay), I will take a look at thee fork and see if it suits my needs I have another question concerning the project, does it support retry ? I'm trying to evaluate if smtprelay can be setup between my service and another SMTP server (why ? It's not available as much as I'd like) ``` ┌─────────┐ ┌───────────┐ ┌─────────────┐ │ service ├─────►│ smtprelay ├──x──►│ smtp server │ └─────────┘ └───────────┘ └─────────────┘ ```

kerem commented

2026-02-26 18:32:58 +03:00

Author

Owner

@decke commented on GitHub (Feb 26, 2022):

smtprelay does not store and forward if that is your question. It forwards directly so retry is needed on the sending side.

@decke commented on GitHub (Feb 26, 2022): smtprelay does not store and forward if that is your question. It forwards directly so retry is needed on the sending side.

kerem referenced this issue

2026-02-26 18:33:12 +03:00

[PR #15] [MERGED] Add structured logging via logrus #59

kerem referenced this issue

2026-02-26 18:33:12 +03:00

[PR #13] [CLOSED] Production-readiness modifications #60

kerem referenced this issue

2026-02-26 18:33:12 +03:00

[PR #18] [MERGED] Allow any network and related enhancements #61

kerem referenced this issue

2026-02-26 18:33:13 +03:00

[PR #17] [CLOSED] Handle signals and gracefully shut down #62