[GH-ISSUE #277] Loss of a sms/mms or call log if an exception occurs during backup #231

Closed
opened 2026-02-26 00:36:35 +03:00 by kerem · 1 comment
Owner

Originally created by @mBalducci on GitHub (Dec 5, 2012).
Original GitHub issue: https://github.com/jberkel/sms-backup-plus/issues/277

Looking the source code i saw the MaxSyncedDate is setted before doing "appendMessages", this cause the loss of that message if an exception occurs.

updateMaxSyncedDateMms(result.maxDate);
smsmmsfolder.appendMessages(messages.toArray(new Message[messages.size()]));

should be

smsmmsfolder.appendMessages(messages.toArray(new Message[messages.size()]));
updateMaxSyncedDateMms(result.maxDate);
Originally created by @mBalducci on GitHub (Dec 5, 2012). Original GitHub issue: https://github.com/jberkel/sms-backup-plus/issues/277 Looking the source code i saw the MaxSyncedDate is setted before doing "appendMessages", this cause the loss of that message if an exception occurs. ``` java updateMaxSyncedDateMms(result.maxDate); smsmmsfolder.appendMessages(messages.toArray(new Message[messages.size()])); ``` should be ``` java smsmmsfolder.appendMessages(messages.toArray(new Message[messages.size()])); updateMaxSyncedDateMms(result.maxDate); ```
kerem closed this issue 2026-02-26 00:36:35 +03:00
Author
Owner

@jberkel commented on GitHub (Jan 13, 2013):

would you mind open a PR with this change?

<!-- gh-comment-id:12193502 --> @jberkel commented on GitHub (Jan 13, 2013): would you mind open a PR with this change?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sms-backup-plus-jberkel#231
No description provided.