mirror of
https://github.com/jberkel/sms-backup-plus.git
synced 2026-04-25 17:05:59 +03:00
[GH-ISSUE #2] Mark restored messages as read #1
Labels
No labels
AM+RCS
FAQ
awaiting response
backup
bespoke
bug
calendar
call log
cannot reproduce
cloudless
device-specific
documentation
dual- & multi-SIM
duplicate
feature-request
fixed in beta
good first issue
half-missing
help wanted
helpful
meta
misattribution
mms
other message sources
pull-request
question
rejuvenation
restore
schedule
security
stale
task
thanks
v1.5.1
v1.5.10
v1.5.11
v1.5.2
v1.5.3
v1.5.3
v1.5.4
v1.5.4
v1.5.5
v1.5.5
v1.5.6
v1.5.7
v1.5.8
v1.5.9
v1.6β
xoauth
~$ bounty $~
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/sms-backup-plus-jberkel#1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @erikwt on GitHub (Mar 14, 2010).
Original GitHub issue: https://github.com/jberkel/sms-backup-plus/issues/2
When restoring messages, they appear as unread messages in the SMS application.
@jberkel commented on GitHub (Mar 14, 2010):
do they all consistently appear as unread? which phone/version of android are you using?
@erikwt commented on GitHub (Mar 29, 2010):
All restored messages were marked unread. I compiled your source myself on target 'android 2.1' and ran it on a custom 2.1 rom (Villain) on my HTC Hero.
@jberkel commented on GitHub (Mar 29, 2010):
could you post the x-smssync headers of one of your backed up emails here? i've only tested with 1.6 so far.
@erikwt commented on GitHub (Mar 29, 2010):
X-smssync-id: 2866
X-smssync-address: +**********
X-smssync-type: 1
X-smssync-date: 1269865905000
X-smssync-thread: 1
X-smssync-read: 1
X-smssync-status: -1
X-smssync-protocol: 0
X-smssync-service_center: +**********
X-smssync-backup_time: 29 Mar 2010 12:32:28 GMT
@jberkel commented on GitHub (Mar 29, 2010):
looks like the sms gets serialized properly (smssync-read: 1). there's probably some db trigger setting all new messages to unread on 2.1. i'll try it in an emulator.
@jberkel commented on GitHub (Mar 29, 2010):
sorry can't reproduce. you might need to wait until the end of the restore, the threading data will get updated then. if you want to some further debugging, you could pull the sms db off your phone and inspect it manually:
@ntziolis commented on GitHub (May 5, 2010):
Had a very similar issue, but for me NOT ALL restored sms were marked as unread, just about 70 out of 360.
I added one of the headers:
X-smssync-id: 298
X-smssync-address: +
X-smssync-type: 1
X-smssync-date: 1270805793000
X-smssync-thread: 40
X-smssync-read: 0
X-smssync-status: -1
X-smssync-protocol: 0
X-smssync-service_center: +
X-smssync-backup_time: 9 Apr 2010 09:37:27 GMT
I checked a couple of the 70 messages and they all had the header:
X-smssync-read: 0
My guess is that the messages were backed up before I could read them. Maybe on restore they should always been set to read, or when pressing restore you should be asked if all restored messages should be set to read or if the value in the header should be taken.
My Setup:
HTC Hero, Android 2.1, Villain 5.5 Custom ROM
@jberkel commented on GitHub (May 5, 2010):
ah of course, was this with automatic backup enabled? good idea to make it an option on restore, i'm going to implement that.
@ntziolis commented on GitHub (May 5, 2010):
yes indeed, automatic backup was enabled.
Nice to hear that its going to be in the next version. Any clues why the restore is not in the main trunk by now? At least as experimental feature?
@jberkel commented on GitHub (May 5, 2010):
I sent the original author several emails, asking whether he planned to merge my changes back in, but haven't heard back from him since. There have been no commits on the main project since end of january, maybe he's lost interest. My plan is to do some more cleanups and then release a new version with restoring to the market. I'd like to avoid having to fork the project but i don't see any other option at the moment.
@ntziolis commented on GitHub (May 5, 2010):
Well all you can do is try. Thx for your contributions so far. Looking forward to the new version.
@jberkel commented on GitHub (Jul 6, 2010):
Optionally mark all messages as read on restore.
Closed by 0f581921d6cca58348ef4d19b034f7807fc22cad.
@jberkel commented on GitHub (Jul 6, 2010):
could you try install version 1.1.2 from http://github.com/jberkel/android-sms/downloads and see if that helps? there's now a checkbox to mark restored messages as read, in advanced settings.