[PR #872] [MERGED] fix: api calls using absolute urls #832

New issue

Closed

opened 2026-02-25 23:35:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/872
Author: @fmartingr
Created: 3/31/2024
Status: ✅ Merged
Merged: 4/7/2024
Merged by: @fmartingr

Base: master ← Head: fmartingr/issue870

📝 Commits (2)

9a25857 Use relative path for API calls
079d2ae Merge branch 'master' into fmartingr/issue870

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 internal/view/assets/js/page/setting.js (+2 -2)

📄 Description

Some API calls were using an absolute path ignoring the base href element thus not working/pointing where it shouldn't.

Fixes #870

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/872 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 4/7/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fmartingr/issue870` --- ### 📝 Commits (2) - [`9a25857`](https://github.com/go-shiori/shiori/commit/9a2585716c0ddde19ae4b8959711d9f01f0604c5) Use relative path for API calls - [`079d2ae`](https://github.com/go-shiori/shiori/commit/079d2ae0760371202badb862710fbea1d736b1e1) Merge branch 'master' into fmartingr/issue870 ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/js/page/setting.js` (+2 -2) </details> ### 📄 Description Some API calls were using an absolute path ignoring the `base href` element thus not working/pointing where it shouldn't. Fixes #870 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>