[PR #925] [CLOSED] refactor : improve frontend code base #872

New issue

Closed

opened 2026-02-25 23:35:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/925
Author: @Monirzadeh
Created: 6/2/2024
Status: ❌ Closed

Base: master ← Head: fix-front-end-warrning

📝 Commits (4)

b7e4800 replace var with const or let
734378d loop instead of multiple if
19de012 use switch instead of if and unifiy variable create in frontend
df95e81 fix style

📊 Changes

6 files changed (+109 additions, -103 deletions)

View changed files

📝 internal/view/assets/js/component/bookmark.js (+2 -2)
📝 internal/view/assets/js/component/dialog.js (+33 -23)
📝 internal/view/assets/js/component/pagination.js (+1 -1)
📝 internal/view/assets/js/page/base.js (+11 -15)
📝 internal/view/assets/js/page/home.js (+57 -57)
📝 internal/view/assets/js/page/setting.js (+5 -5)

📄 Description

current frontend code base has multiple problem that i try to solve some of them in this PR

TODO:

unify variable name creation and replace all var with const or let to control variable scope
minor improvement
change unneeded if to switch for better performance
review all the changes

may update over time
should wait until #924 merge some errors solve there

@fmartingr any specific suggestion?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/925 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 6/2/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-front-end-warrning` --- ### 📝 Commits (4) - [`b7e4800`](https://github.com/go-shiori/shiori/commit/b7e48008341d7cef85f7af687723c20d5e218db6) replace var with const or let - [`734378d`](https://github.com/go-shiori/shiori/commit/734378d92ad53cb31a3797f531a79afcfe662edc) loop instead of multiple if - [`19de012`](https://github.com/go-shiori/shiori/commit/19de0123eab5ccddf42a297b801682c1ca5c93e3) use switch instead of if and unifiy variable create in frontend - [`df95e81`](https://github.com/go-shiori/shiori/commit/df95e81561caadca86943a0536ed2cf1011609ab) fix style ### 📊 Changes **6 files changed** (+109 additions, -103 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/js/component/bookmark.js` (+2 -2) 📝 `internal/view/assets/js/component/dialog.js` (+33 -23) 📝 `internal/view/assets/js/component/pagination.js` (+1 -1) 📝 `internal/view/assets/js/page/base.js` (+11 -15) 📝 `internal/view/assets/js/page/home.js` (+57 -57) 📝 `internal/view/assets/js/page/setting.js` (+5 -5) </details> ### 📄 Description current frontend code base has multiple problem that i try to solve some of them in this PR # TODO: - [x] unify variable name creation and replace all var with const or let to control variable scope - [x] minor improvement - [ ] change unneeded if to switch for better performance - [ ] review all the changes *may update over time* *should wait until #924 merge some errors solve there* @fmartingr any specific suggestion? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>