[PR #732] [MERGED] feat: allow resize the dialogbox for bigger/hidpi screens #758

Closed
opened 2026-02-25 23:35:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/732
Author: @Monirzadeh
Created: 9/14/2023
Status: Merged
Merged: 10/9/2023
Merged by: @fmartingr

Base: masterHead: resize-dialog-box-in-hi-res-display


📝 Commits (10+)

  • 86487f1 resize dialogbox with drag corner of box
  • 9f3b365 Merge branch 'master' into resize-dialog-box-in-hi-res-display
  • 7189c0f merge master to this branch
  • 5d27193 update style.css
  • ad37b5b resizable just for more than full HD display
  • f7c64f7 fix size for initial size for small and big size
  • 9b48371 Merge branch 'master' into resize-dialog-box-in-hi-res-display
  • 76f17ea full screen dialog box on mobile device - wider dialogbox on device
  • 3f6391c remvoe custom-dialog.css that combine with style.css
  • 9c69e21 Merge branch 'master' into resize-dialog-box-in-hi-res-display

📊 Changes

2 files changed (+19 additions, -4 deletions)

View changed files

📝 internal/view/assets/css/style.css (+1 -1)
📝 internal/view/assets/less/custom-dialog.less (+18 -3)

📄 Description

this pull request try to improve UX in wide screen or High-resolution display.
it should close #731
for now it is not complete yet,

TODO:

  • resize box
  • just active when display is bigger than full HD
  • remove max-width or change that to 800px if resize box is active

Things we don't decide about them yet

  • should new resize size remmeber?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/732 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 9/14/2023 **Status:** ✅ Merged **Merged:** 10/9/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `resize-dialog-box-in-hi-res-display` --- ### 📝 Commits (10+) - [`86487f1`](https://github.com/go-shiori/shiori/commit/86487f16917f9be7b990035826ed5eed016f8cb1) resize dialogbox with drag corner of box - [`9f3b365`](https://github.com/go-shiori/shiori/commit/9f3b365f2f72ab9adeec90e15431d0312df8c646) Merge branch 'master' into resize-dialog-box-in-hi-res-display - [`7189c0f`](https://github.com/go-shiori/shiori/commit/7189c0fb35e6c74956bd054435d1356659326f7c) merge master to this branch - [`5d27193`](https://github.com/go-shiori/shiori/commit/5d2719308e6bf8e33fd7032f69b75d5a985be8bc) update style.css - [`ad37b5b`](https://github.com/go-shiori/shiori/commit/ad37b5bd7c6e2e08928656169ca2e9a4759e3f55) resizable just for more than full HD display - [`f7c64f7`](https://github.com/go-shiori/shiori/commit/f7c64f7bd189f982b9cb45225f8c71ea026dbbde) fix size for initial size for small and big size - [`9b48371`](https://github.com/go-shiori/shiori/commit/9b483711c154d4ea4be80e4dec0d551a42a839b7) Merge branch 'master' into resize-dialog-box-in-hi-res-display - [`76f17ea`](https://github.com/go-shiori/shiori/commit/76f17ea0ea4cf0a832aef83b217e33851262980b) full screen dialog box on mobile device - wider dialogbox on device - [`3f6391c`](https://github.com/go-shiori/shiori/commit/3f6391c1a01c3b94106dd490ebea7863ca9db086) remvoe custom-dialog.css that combine with style.css - [`9c69e21`](https://github.com/go-shiori/shiori/commit/9c69e217a08dafc213fabd153432578b24178259) Merge branch 'master' into resize-dialog-box-in-hi-res-display ### 📊 Changes **2 files changed** (+19 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/css/style.css` (+1 -1) 📝 `internal/view/assets/less/custom-dialog.less` (+18 -3) </details> ### 📄 Description this pull request try to improve UX in wide screen or High-resolution display. it should close #731 for now it is not complete yet, # TODO: - [x] resize box - [x] just active when display is bigger than full HD - [x] remove `max-width` or change that to 800px if resize box is active # Things we don't decide about them yet - [ ] should new resize size remmeber? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#758
No description provided.