[PR #687] [MERGED] preserve fragment in URLs (#315) #731

New issue

Closed

opened 2026-02-25 23:35:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/687
Author: @arakimo
Created: 7/30/2023
Status: ✅ Merged
Merged: 8/5/2023
Merged by: @fmartingr

Base: master ← Head: issue315

📝 Commits (3)

d599674 preserve fragment in URLs (#315)
dbcce07 fix: correctly handle URLs without a fragment
155c66a simplify solution to (#315)

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 internal/core/url.go (+0 -1)

📄 Description

I encountered this issue myself while using shiori, so I figured I would have a go. I'm fairly new to git/programming, so... apologies in advance for any mistakes :)

Should fix #315

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/687 **Author:** [@arakimo](https://github.com/arakimo) **Created:** 7/30/2023 **Status:** ✅ Merged **Merged:** 8/5/2023 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `issue315` --- ### 📝 Commits (3) - [`d599674`](https://github.com/go-shiori/shiori/commit/d5996747a949bb09d75c15f93bf386631d8f817a) preserve fragment in URLs (#315) - [`dbcce07`](https://github.com/go-shiori/shiori/commit/dbcce076931f578bbdd6957308a2c9c50fdd2b2b) fix: correctly handle URLs without a fragment - [`155c66a`](https://github.com/go-shiori/shiori/commit/155c66a29e97f21c984dda4cc559cc2a8ed0b5dc) simplify solution to (#315) ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/url.go` (+0 -1) </details> ### 📄 Description I encountered this issue myself while using shiori, so I figured I would have a go. I'm fairly new to git/programming, so... apologies in advance for any mistakes :) Should fix #315 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>