[PR #413] [MERGED] fix: bookmark content download #588

Closed
opened 2026-02-25 23:34:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/413
Author: @fmartingr
Created: 3/27/2022
Status: Merged
Merged: 3/27/2022
Merged by: @fmartingr

Base: masterHead: fix/bookmark-extract-content


📝 Commits (1)

  • 60e3064 fix: bookmark content download

📊 Changes

1 file changed (+28 additions, -21 deletions)

View changed files

📝 internal/webserver/handler-api.go (+28 -21)

📄 Description

Fixed a bug where the content of the article would archive but the
reader version would not be saved due to variable passing. Also made the
code easier to follow by following return principles.

Fixes #406


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/413 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 3/27/2022 **Status:** ✅ Merged **Merged:** 3/27/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/bookmark-extract-content` --- ### 📝 Commits (1) - [`60e3064`](https://github.com/go-shiori/shiori/commit/60e30648a4420848afb9062dc1fae8c8686ac5fc) fix: bookmark content download ### 📊 Changes **1 file changed** (+28 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `internal/webserver/handler-api.go` (+28 -21) </details> ### 📄 Description Fixed a bug where the content of the article would archive but the reader version would not be saved due to variable passing. Also made the code easier to follow by following return principles. Fixes #406 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:34:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#588
No description provided.