[GH-ISSUE #918] PUT request to /api/v1/bookmarks/cache takes too long #413

Open
opened 2026-02-25 23:34:10 +03:00 by kerem · 2 comments
Owner

Originally created by @DesarrolloAntonio on GitHub (May 21, 2024).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/918

Data

  • Shiori version: 1.6.3

Describe the bug / actual behavior

I have an Android app that interacts with Shiori's API. When I attempt to update a bookmark archive, the request takes an excessively long time, often several minutes when is a large bookmark.

Endpoint:
PUT http://192.168.1.68:18080/api/v1/bookmarks/cache

{
   "create_archive": true,
   "create_ebook": true,
   "ids": [37],
   "keep_metadata": true,
   "skip_exist": false
}

Initially, the timeout in android app was set to 30 seconds. I increased it to 50 seconds, but there are still bookmarks that I cannot update because the request times out.

It seems that the timeout issue is related to the length of the bookmark. Here is an example of large bookmark that causes this issue.
large bookmark

Expected behavior

The server should return the bookmark information promptly while creating the archive in the background.

To Reproduce

Steps to reproduce the behavior:

  1. Add large bookmark
  2. Update archive
Originally created by @DesarrolloAntonio on GitHub (May 21, 2024). Original GitHub issue: https://github.com/go-shiori/shiori/issues/918 ## Data - **Shiori version**: 1.6.3 ## Describe the bug / actual behavior I have an Android app that interacts with Shiori's API. When I attempt to update a bookmark archive, the request takes an excessively long time, often several minutes when is a large bookmark. Endpoint: **PUT http://192.168.1.68:18080/api/v1/bookmarks/cache** ``` { "create_archive": true, "create_ebook": true, "ids": [37], "keep_metadata": true, "skip_exist": false } ``` Initially, the timeout in android app was set to 30 seconds. I increased it to 50 seconds, but there are still bookmarks that I cannot update because the request times out. It seems that the timeout issue is related to the length of the bookmark. Here is an example of large bookmark that causes this issue. [large bookmark](https://levelup.gitconnected.com/how-i-built-a-social-network-in-4-years-as-a-solo-developer-4af70fb2d4c8 ) ## Expected behavior The server should return the bookmark information promptly while creating the archive in the background. ## To Reproduce Steps to reproduce the behavior: 1. Add large bookmark 2. Update archive
Author
Owner

@fmartingr commented on GitHub (May 25, 2024):

Yeah, currently the data download task is a sync process. We could just launch this in background but right now we don't have means of telling the user what's the status of a background job. I'm currently working in something for that but is far from ready and it have other implications due to the nature of the bookmarks being available to all users at the moment.

<!-- gh-comment-id:2130924113 --> @fmartingr commented on GitHub (May 25, 2024): Yeah, currently the data download task is a sync process. We could just launch this in background but right now we don't have means of telling the user what's the status of a background job. I'm currently working in something for that but is far from ready and it have other implications due to the nature of the bookmarks being available to all users at the moment.
Author
Owner

@fmartingr commented on GitHub (May 28, 2024):

Reopening for future reference.

<!-- gh-comment-id:2134875054 --> @fmartingr commented on GitHub (May 28, 2024): Reopening for future reference.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#413
No description provided.