mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #579] Article reading page doesn't provide link back to main Shiori page #310
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#310
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @axelsimon on GitHub (Feb 16, 2023).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/579
Hi!
Data
Describe the bug / actual behaviour
Clicking on an article opens a new tab to read the article. This tab contains no link back to the main Shiori interface.
Expected behaviour
I expect to be able to go back to the main Shiori interface from an article served by Shiori.
Notes
I get that the idea is to have a main Shiori page and each article open in a new tab. Not having a link back to the main Shiori interface reduces the risk of people ending up with multiple tabs with the main Shiori page open, but not everyone wants to open everything in new tabs all the time :)
@Monirzadeh commented on GitHub (Jul 1, 2023):
@fmartingr somehow I agree. We can do both and user can be select between them in settings.
if you don't have a problem with that (make codebase bigger for this kind of setting) I can do that.
I think open in current tab is better option. User can be always open in new tab.
@fmartingr commented on GitHub (Jul 2, 2023):
I just got used to the fact that the article opens in a new tab and just close it when I want to go back to the main Shiori interface. I keep thinking that maybe we should add the readable to the main javascript interface instead of serve that in the backend, but it's some discussion I want to have once I finish the new API (#497). I should sit down and elaborate a proper roadmap too.
@Monirzadeh commented on GitHub (Jul 2, 2023):
I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Personally, I prefer to keep shiori keep fast as possible. I am tired of all heavy slow project out there.
About roadmap, I like that idea. I suggest review KOReader project. How it is good to organize, maybe you can find good point there.
@fmartingr commented on GitHub (Jul 2, 2023):
Yeah, both ways can coexist, but on my mind, if I'm using the JS interface, I'd prefer everything to load that way. Helps making a PWA for mobile devices easier to develop too. But again, just random thoughts on my head.
In this particular case, since we open a new tab for article content, a "go back" equals to a "
window.close()".