[PR #378] [MERGED] fix: trying to mkdir over an incorrect data path #579

New issue

Closed

opened 2026-02-25 23:34:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:34:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/378
Author: @fmartingr
Created: 2/22/2022
Status: ✅ Merged
Merged: 2/23/2022
Merged by: @fmartingr

Base: master ← Head: fix/datadir

📝 Commits (1)

e001247 fix: data path without a filename

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/cmd/root.go (+1 -1)

📄 Description

The migration to the latest dependencies made a change on the library we use to retrieve data directories. In this case the path we were trying to get should be ~/.local/share/shiori/ and we were returning ~/.local/share/shiori/shiori.db as a path, so users upgrading from 1.5.0 experienced an error when shiori tried to create that path hierarchy. This should fix that problem but we still need to address #377 to prevent problems for people migrating from 1.5.0.

Relates to #291

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/378 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 2/22/2022 **Status:** ✅ Merged **Merged:** 2/23/2022 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/datadir` --- ### 📝 Commits (1) - [`e001247`](https://github.com/go-shiori/shiori/commit/e00124791d317617898b6866cdd7b917b762045e) fix: data path without a filename ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/root.go` (+1 -1) </details> ### 📄 Description The migration to the latest dependencies made a change on the library we use to retrieve data directories. In this case the path we were trying to get should be `~/.local/share/shiori/` and we were returning `~/.local/share/shiori/shiori.db` **as a path**, so users upgrading from 1.5.0 experienced an error when shiori tried to create that path hierarchy. This should fix that problem but we still need to address #377 to prevent problems for people migrating from 1.5.0. Relates to #291 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>