mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #244] Images not being archived #181
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#181
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vorkuta on GitHub (Apr 28, 2020).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/244
Have installed the latest release of 18.04 - shiori-linux-amd64-stretch
Most of the links do not seem to be saving images when addings.
link
The first time I loaded this, the first image loaded. The second time (redownloaded) and I lost all of the images. I had a search of the GitHub images, but it said it had been fixed.
@8bitgentleman commented on GitHub (Apr 29, 2020):
I just tried the same link on my fresh docker install and Shiori got all of the images just fine
@vorkuta commented on GitHub (Apr 29, 2020):
I'm running shiori-linux-amd64-stretch from precompiled binary, not a docker install, but thanks for the input.
@vorkuta commented on GitHub (Apr 29, 2020):
As an update, had a look at the source html for this specific content view.
<img data-pin-title="Oaxacan Lamb Barbacoa!" src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20750%201125'%3E%3C/svg%3E" alt="Mexican Lamb Barbacoa - a simple delicious recipe from Oaxaca that results in tender, juicy falling off the bone lamb perfect for tacos and burritos! #tacos #barbacoa #lamb #lambrecipes #oaxaca #mexicanrecipes #cincodemayo " data-pin-description="Mexican Lamb Barbacoa - a simple delicious recipe from Oaxaca that results in tender, juicy falling off the bone lamb perfect for tacos and burritos! #tacos #barbacoa #lamb #lambrecipes #oaxaca #mexicanrecipes #cincodemayo " data-lazy-src="https://www.feastingathome.com/wp-content/uploads/2019/04/Lamb-Barbacao-Recipe-116.jpg" srcset="" width="750" height="1125">I don't know what the difference is between src and data-lazy-src, but there may be an issue with the src?
src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20750%201125'%3E%3C/svg%3E"If anyone has some examples of how image code is supposed to lookl that would be appreciated.
@vorkuta commented on GitHub (Apr 29, 2020):
If it's relevant, I don't know if exerpts are supposed to be displayed on the main bookmark list/tile view, but I only the image, title, url etc., can't see an exerpt. Image attached.
@fmartingr commented on GitHub (Oct 7, 2022):
Any problem with the archives will get worked on with the switch to obelisk #353. After the switch, we can start fixing things directly on obelisk.