starred/shiori

Fork 0

mirror of https://github.com/go-shiori/shiori.git synced 2026-04-25 06:25:54 +03:00

[GH-ISSUE #386] Load tags dynamically using the API instead of on page first load #244

New issue

Open

opened 2026-02-25 23:33:47 +03:00 by kerem · 10 comments

kerem commented

2026-02-25 23:33:47 +03:00

Owner

Originally created by @thelazyoxymoron on GitHub (Feb 25, 2022).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/386

I'm not able to select any tags from the matched list. Using the Arm64 docker image built using the latest codebase.

Originally created by @thelazyoxymoron on GitHub (Feb 25, 2022). Original GitHub issue: https://github.com/go-shiori/shiori/issues/386 I'm not able to select any tags from the matched list. Using the Arm64 docker image built using the latest codebase.

kerem added the

type:bug

label

2026-02-25 23:33:47 +03:00

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@fmartingr commented on GitHub (Feb 26, 2022):

Where do you have this problem? In the search, in the article list, in the tag list, in the "add bookmark" dialog?

@fmartingr commented on GitHub (Feb 26, 2022): Where do you have this problem? In the search, in the article list, in the tag list, in the "add bookmark" dialog?

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@thelazyoxymoron commented on GitHub (Feb 27, 2022):

I'm facing this in the add new bookmark screen, as well as when I try to edit an existing bookmark. DB is Postgresql.

@thelazyoxymoron commented on GitHub (Feb 27, 2022): I'm facing this in the add new bookmark screen, as well as when I try to edit an existing bookmark. DB is Postgresql.

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@fmartingr commented on GitHub (Mar 1, 2022):

Just to confirm, the problem is that you don't see the tags input like this:

Which browser are you suing?

@fmartingr commented on GitHub (Mar 1, 2022): Just to confirm, the problem is that you don't see the tags input like this: ![2022-03-01_12-32-36](https://user-images.githubusercontent.com/812088/156170000-13e7b4af-184d-42a6-bf26-3dbf1b9af3d4.png) Which browser are you suing?

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@thelazyoxymoron commented on GitHub (Mar 5, 2022):

Just to confirm, the problem is that you don't see the tags input like this:

I see the tags input getting suggested, but not able to select from the suggested list.

Which browser are you suing?

Firefox v97

@thelazyoxymoron commented on GitHub (Mar 5, 2022): > Just to confirm, the problem is that you don't see the tags input like this: I see the tags input getting suggested, but not able to select from the suggested list. > Which browser are you suing? Firefox v97

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@fmartingr commented on GitHub (Mar 5, 2022):

I've just tried this on Firefox 97.0.2 @ macos 12.1 and it's working:

https://user-images.githubusercontent.com/812088/156902737-53594b4c-f055-4fc4-8e8f-57195ecf2ed7.mov

I put a few letters and press enter on the suggestion.

Do you see any errors on the firefox console? Tools > Browser Tools > Developer Tools on the Console tab.

@fmartingr commented on GitHub (Mar 5, 2022): I've just tried this on Firefox 97.0.2 @ macos 12.1 and it's working: https://user-images.githubusercontent.com/812088/156902737-53594b4c-f055-4fc4-8e8f-57195ecf2ed7.mov I put a few letters and press enter on the suggestion. Do you see any errors on the firefox console? `Tools > Browser Tools > Developer Tools` on the `Console` tab.

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@mrex commented on GitHub (Sep 30, 2022):

After finding this bug report, I guess I finally understand how tag suggestions are supposed to work. It looks like Shiori's suggestion shows only one of the possible tags, and only when the text entered does not match the suggestion anymore, another possible tag is shown.

That's not intuitive at all. Usually, when you enter a tag the suggestions show all the tags matching the substring typed so far, with a way to select one of the (possibly multiple) suggested tags, either by navigating with the keyboard or by clicking on it.

@mrex commented on GitHub (Sep 30, 2022): After finding this bug report, I guess I finally understand how tag suggestions are supposed to work. It looks like Shiori's suggestion shows only one of the possible tags, and only when the text entered does not match the suggestion anymore, another possible tag is shown. That's not intuitive at all. Usually, when you enter a tag the suggestions show all the tags matching the substring typed so far, with a way to select one of the (possibly multiple) suggested tags, either by navigating with the keyboard or by clicking on it.

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@fmartingr commented on GitHub (Oct 3, 2022):

Moving this from bug to enhancement, and while agree that the current selector is not optimal I can't consider this a "bug" since it's working as expected. At least until we improve it :)

@thelazyoxymoron if you are experiencing an actual bug please report back so we can take a look at it (and proper triage a new issue for the feature request).

@fmartingr commented on GitHub (Oct 3, 2022): Moving this from bug to enhancement, and while agree that the current selector is not optimal I can't consider this a "bug" since it's working as expected. At least until we improve it :) @thelazyoxymoron if you are experiencing an actual bug please report back so we can take a look at it (and proper triage a new issue for the feature request).

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@thelazyoxymoron commented on GitHub (Oct 4, 2022):

Apologies for not providing enough information earlier. I did some more testing and looks like this is only happening with Postgres DB backend and only when I try to add a tag in the following window:

I did not observe this when trying to edit an existing bookmark and add tags. The auto-suggest + enter was working there. Only observing when adding tags in the "add new bookmar" screen.

This is related to #215.

@thelazyoxymoron commented on GitHub (Oct 4, 2022): Apologies for not providing enough information earlier. I did some more testing and looks like this is only happening with Postgres DB backend and only when I try to add a tag in the following window: ![image](https://user-images.githubusercontent.com/9106868/193747155-a6e60378-9166-4634-832f-dfd32328c845.png) I did not observe this when trying to edit an existing bookmark and add tags. The auto-suggest + enter was working there. Only observing when adding tags in the "add new bookmar" screen. This is related to #215.

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@fmartingr commented on GitHub (Oct 4, 2022):

I've been testing this locally, and after #484 fix for PSQL it now works but there's a caveheat: the frontend loads tags on page load, so if you add a new bookmark with a new tag and then add another bookmark that new tag wont autocomplete unless the page is reloaded.

@fmartingr commented on GitHub (Oct 4, 2022): I've been testing this locally, and after #484 fix for PSQL it now works but there's a caveheat: the frontend loads tags on page load, so if you add a new bookmark with a new tag and then add another bookmark that new tag wont autocomplete unless the page is reloaded.

kerem commented

2026-02-25 23:33:47 +03:00

Author

Owner

@v-marinkov commented on GitHub (Feb 19, 2024):

I also confirm I can't click on the suggested tags (Docker, sqlite3, Firefox, Windows). It would be great to have the tags suggestion in the browser extension too (https://github.com/go-shiori/shiori-web-ext/issues/64)

@v-marinkov commented on GitHub (Feb 19, 2024): I also confirm I can't click on the suggested tags (Docker, sqlite3, Firefox, Windows). It would be great to have the tags suggestion in the browser extension too (https://github.com/go-shiori/shiori-web-ext/issues/64)