[GH-ISSUE #18] Unable to put empty string as excerpt #12

New issue

Closed

opened 2026-02-25 23:33:15 +03:00 by kerem · 2 comments

kerem commented

2026-02-25 23:33:15 +03:00

Owner

Originally created by @sascha-andres on GitHub (Mar 2, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/18

The excerpt extraction for https://www.programming-books.io/essential/go/ does not work as expected.

It displays ↑ ↓ to navigate ↵ to select Esc to close and even when I edit the excerpt to have it empty, it fills in the excerpt again.

My expected behaviour would have been to be able to set the excerpt explicitly to an empty string

Originally created by @sascha-andres on GitHub (Mar 2, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/18 The excerpt extraction for `https://www.programming-books.io/essential/go/` does not work as expected. It displays `↑ ↓ to navigate ↵ to select Esc to close` and even when I edit the excerpt to have it empty, it fills in the excerpt again. My expected behaviour would have been to be able to set the excerpt explicitly to an empty string

kerem

2026-02-25 23:33:15 +03:00

closed this issue
added the
type:bug
label

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@peteretelej commented on GitHub (Mar 2, 2018):

Empty excerpts seem to be overwritten during update github.com/RadhiFadlillah/shiori@3826d4b7ab/cmd/update.go (L149-L151)
whitespace characters are also trimmed during input, hence will be overwritten.
github.com/RadhiFadlillah/shiori@3826d4b7ab/view/index.html (L74)
also applies for the title. I think deleting the excerpt at least would be nice, maybe an additional table column for deletedexcerpt, or using a character like '-' for deleted excerpts and replacing when displaying/reading

@peteretelej commented on GitHub (Mar 2, 2018): Empty excerpts seem to be overwritten during update https://github.com/RadhiFadlillah/shiori/blob/3826d4b7ab346a539ea3457c1402b19ea68b4f71/cmd/update.go#L149-L151 whitespace characters are also trimmed during input, hence will be overwritten. https://github.com/RadhiFadlillah/shiori/blob/3826d4b7ab346a539ea3457c1402b19ea68b4f71/view/index.html#L74 also applies for the title. I think deleting the excerpt at least would be nice, maybe an additional table column for deletedexcerpt, or using a character like '-' for deleted excerpts and replacing when displaying/reading

kerem commented

2026-02-25 23:33:15 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 6, 2018):

Fixed in 9d3c8ee.

It's quite a dirty hack, however it's simple and works, so I think it's good enough for now.

@RadhiFadlillah commented on GitHub (Mar 6, 2018): Fixed in [9d3c8ee](https://github.com/RadhiFadlillah/shiori/commit/9d3c8eedf9379edd3ab2bce974e912f4b579ae97). It's quite a dirty hack, however it's simple and works, so I think it's good enough for now.