[GH-ISSUE #30] Change Request: Don't update the index of bookmarks when deleting #18

New issue

Closed

opened 2026-02-25 23:33:16 +03:00 by kerem · 3 comments

kerem commented

2026-02-25 23:33:16 +03:00

Owner

Originally created by @heliostatic on GitHub (Mar 2, 2018).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/30

Today, if you delete a bookmark, it could change the index of other bookmarks.

That changes the cache URL of other bookmarks, which can lead to surprising results if you've recorded that URL somewhere else.

Originally created by @heliostatic on GitHub (Mar 2, 2018). Original GitHub issue: https://github.com/go-shiori/shiori/issues/30 Today, if you delete a bookmark, it could change the index of other bookmarks. That changes the cache URL of other bookmarks, which can lead to surprising results if you've recorded that URL somewhere else.

kerem closed this issue

2026-02-25 23:33:16 +03:00

kerem commented

2026-02-25 23:33:16 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 5, 2018):

Oh yeah, that's true, I haven't thought that far ahead. I make the index changed after delete only because buku does it.

I will remove it as soon as possible.

@RadhiFadlillah commented on GitHub (Mar 5, 2018): Oh yeah, that's true, I haven't thought that far ahead. I make the index changed after delete only because [`buku`](https://github.com/jarun/Buku) does it. I will remove it as soon as possible.

kerem commented

2026-02-25 23:33:16 +03:00

Author

Owner

@heliostatic commented on GitHub (Mar 5, 2018):

Ah, makes sense. Hadn't seen Buku. Really liking Shiori, thanks for your work!

@heliostatic commented on GitHub (Mar 5, 2018): Ah, makes sense. Hadn't seen Buku. Really liking Shiori, thanks for your work!

kerem commented

2026-02-25 23:33:16 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Mar 5, 2018):

I've removed it in 46c88d5.

@RadhiFadlillah commented on GitHub (Mar 5, 2018): I've removed it in [46c88d5](https://github.com/RadhiFadlillah/shiori/commit/46c88d5db5d44a2648e22016bd4cddf795524363).