mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[GH-ISSUE #1394] Patches screen are empty #466
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#466
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @zoxon on GitHub (Oct 16, 2024).
Original GitHub issue: https://github.com/shadps4-emu/shadPS4/issues/1394
The download buttons work, and the patch files downloaded without any problems
Unable to install any patches because the UI is empty
Tested on latest stable (v0.3.0) version and on latest nightly build v0.3.1 (
25de4d6)OS: Windows 11 Pro 23H2 22631.4317
@StevenMiller123 commented on GitHub (Oct 16, 2024):
This isn't an actual issue. There are no patches for Bloodborne v1.00, You need to dump the update file for the game in order to run any patches.
@Hermiten commented on GitHub (Oct 16, 2024):
Maybe it can be a good idea to put something, like a text to say "There is no patches found for this games or this version"
?
@Hermiten commented on GitHub (Oct 16, 2024):
Maybe @DanielSvoboda ?
@DanielSvoboda commented on GitHub (Oct 16, 2024):
@StevenMiller123 That's right, 1.0 doesn't have a patch, only for 1.9.
The patch is downloaded for all games, not just the one currently on the screen, so the message is for all games and doesn't search for the current serial and version.
I think this message is pretty self-explanatory, don't you think? In my opinion, all you need to do is pay attention when reading it.
@Hermiten commented on GitHub (Oct 16, 2024):
That true. But you know people, so it can maybe help to avoid issue like this 🤣
@ElBread3 commented on GitHub (Oct 16, 2024):
Could probably have a text in the middle of the list saying "No patches found for this version :(" when there isn't any found
@DanielSvoboda commented on GitHub (Oct 16, 2024):
This message is already in the emulator.
What I could do is check if the patches being downloaded are compatible with the version and serial number opened in the window and make a personalized warning, but this download only happens once, because it downloads all the patches for all the available games at once, so I don't think it makes sense to change this.
I think it's fine like this, all that's missing is the attention of the person reading it 🧐
@par274 commented on GitHub (Oct 16, 2024):
This is a problem caused by a PR called "Seperate Update". Fixed #1397
It hasn't been included in the main yet.
@DanielSvoboda commented on GitHub (Oct 16, 2024):
There is no patch for this game because there is no patch for the version it is using, 1.0. There is only a patch for version 1.9.
And it was mentioned that version 0.3.0 and PR1392 were used.
Does PR1397 cause the emulator to not recognize the installed version?
@ElBread3 commented on GitHub (Oct 16, 2024):
It's is a side effect of when I was implementing the separate updates (#1026, #1387) it wasn't fully reading the update as I didn't realize the separate update folder contained eboots that needed to be used, and so it uses the old version from the base folder. This is fixed with #1397 and should now fully load updates and work correctly. That's what par274's saying
@zoxon commented on GitHub (Oct 17, 2024):
Thank you. I forget to install patch file.
It would be nice if we had a message to install the patch file after installing the base game, if it's in the same folder.
@DanielSvoboda commented on GitHub (Oct 17, 2024):
yes, I'll try to do that, and maybe make a screen to manage them all, showing which patches are installed and which version of the game is installed.