[PR #3891] Basic implementation of SceNgs2 for HLE #3781

New issue

Open

opened 2026-02-27 22:04:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3891
Author: @Gursukh
Created: 1/3/2026
Status: 🔄 Open

Base: main ← Head: SceNgs2HLE

📝 Commits (3)

2b32823 Implement rack management and streaming support in NGS2 library
0f4e5ff Chore: Changed var names to snake case
dd1451f Chore: clang format fix and GPL license add

📊 Changes

5 files changed (+1458 additions, -121 deletions)

View changed files

➕ src/core/libraries/ngs2/README.md (+325 -0)
📝 src/core/libraries/ngs2/ngs2.cpp (+706 -39)
📝 src/core/libraries/ngs2/ngs2_impl.cpp (+199 -74)
📝 src/core/libraries/ngs2/ngs2_impl.h (+28 -8)
➕ src/core/libraries/ngs2/ngs2_internal.h (+200 -0)

📄 Description

Added RackInternal and VoiceInternal structures to manage racks and voices.
Introduced methods for creating and destroying racks, including default value handling.
Implemented a ring buffer for streaming audio data within VoiceInternal.
Enhanced SystemInternal to manage multiple racks and their associated voices.
Updated SystemSetup and SystemCleanup functions to accommodate new rack management.
Added utility functions for rack ID to index conversion and buffer management.
Introduced WaveformBlockInternal for handling waveform streaming.

There is a README within the NGS2 folder detailing how the library works and possible future work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3891 **Author:** [@Gursukh](https://github.com/Gursukh) **Created:** 1/3/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `SceNgs2HLE` --- ### 📝 Commits (3) - [`2b32823`](https://github.com/shadps4-emu/shadPS4/commit/2b32823764cf3a6bfc5740e09824e616000c5a90) Implement rack management and streaming support in NGS2 library - [`0f4e5ff`](https://github.com/shadps4-emu/shadPS4/commit/0f4e5ffee0e2f571ce6b7cf871b3246d3f07915e) Chore: Changed var names to snake case - [`dd1451f`](https://github.com/shadps4-emu/shadPS4/commit/dd1451f725c0bcb1f8a312523070ede17aa232c9) Chore: clang format fix and GPL license add ### 📊 Changes **5 files changed** (+1458 additions, -121 deletions) <details> <summary>View changed files</summary> ➕ `src/core/libraries/ngs2/README.md` (+325 -0) 📝 `src/core/libraries/ngs2/ngs2.cpp` (+706 -39) 📝 `src/core/libraries/ngs2/ngs2_impl.cpp` (+199 -74) 📝 `src/core/libraries/ngs2/ngs2_impl.h` (+28 -8) ➕ `src/core/libraries/ngs2/ngs2_internal.h` (+200 -0) </details> ### 📄 Description - Added RackInternal and VoiceInternal structures to manage racks and voices. - Introduced methods for creating and destroying racks, including default value handling. - Implemented a ring buffer for streaming audio data within VoiceInternal. - Enhanced SystemInternal to manage multiple racks and their associated voices. - Updated SystemSetup and SystemCleanup functions to accommodate new rack management. - Added utility functions for rack ID to index conversion and buffer management. - Introduced WaveformBlockInternal for handling waveform streaming. There is a README within the NGS2 folder detailing how the library works and possible future work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>