[PR #4039] [MERGED] Lib.VideoOut: Fix pending flips limit #3891

New issue

Closed

opened 2026-02-27 22:05:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/4039
Author: @StevenMiller123
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @georgemoralis

Base: main ← Head: fix-flip-queue-size

📝 Commits (2)

f6d102e Hardcoded limit to pending flips
db593a5 Assert on trying to flip unregistered buffer

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/core/libraries/videoout/driver.cpp (+2 -1)

📄 Description

Real hardware has a fixed limit for pending flips, it doesn't rely on the number of registered VideoOut buffers. While the kernel uses an array of 18 elements, my tests suggest the cap is around 16 pending flips.

I'm not entirely sure if our code is properly equipped to handle this change, but it appears to work fine in games that were previously asserting or spamming the flip queue is full error message.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/4039 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-flip-queue-size` --- ### 📝 Commits (2) - [`f6d102e`](https://github.com/shadps4-emu/shadPS4/commit/f6d102e84b2197827651184ceb05ac30eb9a4e28) Hardcoded limit to pending flips - [`db593a5`](https://github.com/shadps4-emu/shadPS4/commit/db593a5f397cc082580700d56e1a7873ee1dd1b3) Assert on trying to flip unregistered buffer ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/videoout/driver.cpp` (+2 -1) </details> ### 📄 Description Real hardware has a fixed limit for pending flips, it doesn't rely on the number of registered VideoOut buffers. While the kernel uses an array of 18 elements, my tests suggest the cap is around 16 pending flips. I'm not entirely sure if our code is properly equipped to handle this change, but it appears to work fine in games that were previously asserting or spamming the flip queue is full error message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>