[PR #3815] [MERGED] Add assert on SFO file being empty #3733

New issue

Closed

opened 2026-02-27 22:04:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3815
Author: @kalaposfos13
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/24/2025
Merged by: @squidbus

Base: main ← Head: empty-sfo

📝 Commits (1)

f3233b0 Add assert on SFO file being empty

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/core/file_format/psf.cpp (+1 -0)

📄 Description

This PR is related to #3397, and provides a better error message on hitting the titular issue, instead of crashing silently on Windows or crashing with an access violation error elsewhere.

[Lib.SaveData] <Debug> savedata.cpp:1260 sceSaveDataMount: called dirName: PROFILE, mode: 1010, blocks: 320
[Debug] <Critical> psf.cpp:39 operator(): Assertion Failed!
SFO file at /home/kalaposfos/.local/share/shadPS4/savedata/1/CUSA00003/PROFILE/sce_sys/param.sfo is empty!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3815 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/24/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `empty-sfo` --- ### 📝 Commits (1) - [`f3233b0`](https://github.com/shadps4-emu/shadPS4/commit/f3233b09087a3afb5f489857fa07609db0bb1b35) Add assert on SFO file being empty ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/core/file_format/psf.cpp` (+1 -0) </details> ### 📄 Description This PR is related to #3397, and provides a better error message on hitting the titular issue, instead of crashing silently on Windows or crashing with an access violation error elsewhere. ``` [Lib.SaveData] <Debug> savedata.cpp:1260 sceSaveDataMount: called dirName: PROFILE, mode: 1010, blocks: 320 [Debug] <Critical> psf.cpp:39 operator(): Assertion Failed! SFO file at /home/kalaposfos/.local/share/shadPS4/savedata/1/CUSA00003/PROFILE/sce_sys/param.sfo is empty! ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>