[PR #3942] [MERGED] video_core: Small fixes regarding GDS #3815

New issue

Closed

opened 2026-02-27 22:05:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:05:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3942
Author: @raphaelthegreat
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @georgemoralis

Base: main ← Head: gds-fixes

📝 Commits (3)

7681d08 shader_recompiler: Add missing descriptor type for GDS buffer
f1b0f82 liverpool: Implement gds to memory store
7d7be2e macOS fix?

📊 Changes

3 files changed (+33 additions, -14 deletions)

View changed files

📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+13 -4)
📝 src/video_core/amdgpu/liverpool.cpp (+7 -3)
📝 src/video_core/amdgpu/pm4_cmds.h (+13 -7)

📄 Description

First commit fixes an issue where the transformation of GDS atomics to buffer atomics would not set the buffer descriptor type, causing a silent crash in spirv backend due to missing buffer type alias
Implements GDS to memory copy mode of ReleaseMem which affects https://github.com/shadps4-compatibility/shadps4-game-compatibility/issues/581

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3942 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `gds-fixes` --- ### 📝 Commits (3) - [`7681d08`](https://github.com/shadps4-emu/shadPS4/commit/7681d0806807ea8e175e3587b9931df843fa5fd6) shader_recompiler: Add missing descriptor type for GDS buffer - [`f1b0f82`](https://github.com/shadps4-emu/shadPS4/commit/f1b0f82d60017b670ca7d12a06b75de6eabcb018) liverpool: Implement gds to memory store - [`7d7be2e`](https://github.com/shadps4-emu/shadPS4/commit/7d7be2e6f0a2a905612efa63fcb1490b82e1c4c2) macOS fix? ### 📊 Changes **3 files changed** (+33 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+13 -4) 📝 `src/video_core/amdgpu/liverpool.cpp` (+7 -3) 📝 `src/video_core/amdgpu/pm4_cmds.h` (+13 -7) </details> ### 📄 Description * First commit fixes an issue where the transformation of GDS atomics to buffer atomics would not set the buffer descriptor type, causing a silent crash in spirv backend due to missing buffer type alias * Implements GDS to memory copy mode of ReleaseMem which affects https://github.com/shadps4-compatibility/shadps4-game-compatibility/issues/581 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>