[PR #3805] [MERGED] Re-implement custom trophy sounds using sdl3 mixer #3729

New issue

Closed

opened 2026-02-27 22:04:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3805
Author: @rainmakerv3
Created: 11/15/2025
Status: ✅ Merged
Merged: 11/16/2025
Merged by: @georgemoralis

Base: main ← Head: fix-custom-trophy-sound

📝 Commits (3)

1c3ccae re-implement custom trophy sounds using sdl3 mixer
5ba7cc3 fix build vars
3477ec1 Don't change SDL version

📊 Changes

6 files changed (+52 additions, -45 deletions)

View changed files

📝 .gitmodules (+4 -0)
📝 CMakeLists.txt (+2 -1)
📝 externals/CMakeLists.txt (+12 -0)
➕ externals/sdl3_mixer (+1 -0)
📝 src/core/libraries/np/trophy_ui.cpp (+29 -44)
📝 src/core/libraries/np/trophy_ui.h (+4 -0)

📄 Description

Custom trophy sounds used to be played using the Qt media player, presumably because shadPS4 did not have an mp3 decoding library. With the Gui separation, this of course no longer works.

This PR adds the sdl mixer library (https://github.com/libsdl-org/SDL_mixer to address this), and reimplements custom trophy sounds.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3805 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 11/15/2025 **Status:** ✅ Merged **Merged:** 11/16/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-custom-trophy-sound` --- ### 📝 Commits (3) - [`1c3ccae`](https://github.com/shadps4-emu/shadPS4/commit/1c3ccaed4be81763dfed507c589d58aee08d0cb2) re-implement custom trophy sounds using sdl3 mixer - [`5ba7cc3`](https://github.com/shadps4-emu/shadPS4/commit/5ba7cc31948023d739b4d43f27defe63fff45454) fix build vars - [`3477ec1`](https://github.com/shadps4-emu/shadPS4/commit/3477ec10a4f0401c866cc1d5ddc784e64c135eb6) Don't change SDL version ### 📊 Changes **6 files changed** (+52 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+4 -0) 📝 `CMakeLists.txt` (+2 -1) 📝 `externals/CMakeLists.txt` (+12 -0) ➕ `externals/sdl3_mixer` (+1 -0) 📝 `src/core/libraries/np/trophy_ui.cpp` (+29 -44) 📝 `src/core/libraries/np/trophy_ui.h` (+4 -0) </details> ### 📄 Description Custom trophy sounds used to be played using the Qt media player, presumably because shadPS4 did not have an mp3 decoding library. With the Gui separation, this of course no longer works. This PR adds the sdl mixer library (https://github.com/libsdl-org/SDL_mixer to address this), and reimplements custom trophy sounds. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>