[PR #3588] [MERGED] video_core: Check DB_SHADER_CONTROL register before performing depth exports #3594

New issue

Closed

opened 2026-02-27 22:04:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3588
Author: @StevenMiller123
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/13/2025
Merged by: @squidbus

Base: main ← Head: fix-knack

📝 Commits (3)

5a7814b video_core: Check DB_SHADER_CONTROL register before performing depth exports
57e3b70 Update liverpool.h (1)
df42937 Update vk_pipeline_cache.cpp (2)

📊 Changes

4 files changed (+12 additions, -4 deletions)

View changed files

📝 src/shader_recompiler/frontend/translate/export.cpp (+2 -1)
📝 src/shader_recompiler/runtime_info.h (+2 -1)
📝 src/video_core/amdgpu/liverpool.h (+2 -2)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+6 -0)

📄 Description

The DB_SHADER_CONTROL register has several enable flags which must be set before certain depth exports are allowed. This commit adds logic to respect the values in this register when performing depth exports. I've also renamed DepthBufferControl to ShaderControl, since that's closer to the official name for the register.

This fixes the regression seen in the base version of KNACK™ after #3559

Credits to @raphaelthegreat for guiding me through this fix.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3588 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/13/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-knack` --- ### 📝 Commits (3) - [`5a7814b`](https://github.com/shadps4-emu/shadPS4/commit/5a7814bf8bec65da00f62d384e352bf562879368) video_core: Check DB_SHADER_CONTROL register before performing depth exports - [`57e3b70`](https://github.com/shadps4-emu/shadPS4/commit/57e3b70a49e35d972723da53c2bc27c4f79b5f34) Update liverpool.h (1) - [`df42937`](https://github.com/shadps4-emu/shadPS4/commit/df42937a8f2e31f60db40af5be213cdae2abe98b) Update vk_pipeline_cache.cpp (2) ### 📊 Changes **4 files changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/translate/export.cpp` (+2 -1) 📝 `src/shader_recompiler/runtime_info.h` (+2 -1) 📝 `src/video_core/amdgpu/liverpool.h` (+2 -2) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+6 -0) </details> ### 📄 Description The DB_SHADER_CONTROL register has several enable flags which must be set before certain depth exports are allowed. This commit adds logic to respect the values in this register when performing depth exports. I've also renamed DepthBufferControl to ShaderControl, since that's closer to the official name for the register. This fixes the regression seen in the base version of KNACK™ after #3559 Credits to @raphaelthegreat for guiding me through this fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>