[PR #3580] [MERGED] video_core: Upload buffer memory around unmapped pages #3588

New issue

Closed

opened 2026-02-27 22:04:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:04:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3580
Author: @squidbus
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @georgemoralis

Base: main ← Head: buf-copy

📝 Commits (1)

b62e6ea video_core: Upload buffer memory around unmapped pages

📊 Changes

3 files changed (+11 additions, -15 deletions)

View changed files

📝 src/core/memory.cpp (+4 -10)
📝 src/video_core/buffer_cache/buffer_cache.cpp (+2 -2)
📝 src/video_core/page_manager.cpp (+5 -3)

📄 Description

Use CopySparseMemory to copy memory for buffer upload, to copy around unmapped pages.
- Remove prt_areas check optimization in CopySparseMemory to allow this use case.
Bump ClampRangeSize threshold back up as this should handle more cases that would have applied to.
Downgrade GPU memory assert to warning.

Should take care of GPU memory assert in Ratchet & Clank (2016).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3580 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `buf-copy` --- ### 📝 Commits (1) - [`b62e6ea`](https://github.com/shadps4-emu/shadPS4/commit/b62e6ea7de136fe4b828c7330dfde2ae883f3695) video_core: Upload buffer memory around unmapped pages ### 📊 Changes **3 files changed** (+11 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/core/memory.cpp` (+4 -10) 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+2 -2) 📝 `src/video_core/page_manager.cpp` (+5 -3) </details> ### 📄 Description * Use `CopySparseMemory` to copy memory for buffer upload, to copy around unmapped pages. * Remove `prt_areas` check optimization in `CopySparseMemory` to allow this use case. * Bump `ClampRangeSize` threshold back up as this should handle more cases that would have applied to. * Downgrade GPU memory assert to warning. Should take care of GPU memory assert in Ratchet & Clank (2016). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>