hotkeys dialogs while waiting for inputs #3518

New issue

Closed

opened 2026-02-27 22:03:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3499
Author: @rainmakerv3
Created: 9/1/2025
Status: ✅ Merged
Merged: 9/1/2025
Merged by: @squidbus

Base: main ← Head: guiSaveFix

📝 Commits (3)

5ad9c7e prevent saving/canceling dialog while mapping mode is enabled
b5fa3f8 do not disable cancel button
3703fbe diable defaults button

📊 Changes

3 files changed (+22 additions, -0 deletions)

View changed files

📝 src/qt_gui/control_settings.cpp (+8 -0)
📝 src/qt_gui/hotkeys.cpp (+6 -0)
📝 src/qt_gui/kbm_gui.cpp (+8 -0)

📄 Description

this prevents the GUI saving the string "press a button - [3]" that could be done when the save or apply buttons are pressed while the dialog is waiting for inputs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3499 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `guiSaveFix` --- ### 📝 Commits (3) - [`5ad9c7e`](https://github.com/shadps4-emu/shadPS4/commit/5ad9c7e9b6f2e8119fcf518e9d5b9f6622189dd1) prevent saving/canceling dialog while mapping mode is enabled - [`b5fa3f8`](https://github.com/shadps4-emu/shadPS4/commit/b5fa3f8f2d19c9ad9ee035af8b2269842e070ed2) do not disable cancel button - [`3703fbe`](https://github.com/shadps4-emu/shadPS4/commit/3703fbe752f1c2c7b2a81be93617110d07cb00fe) diable defaults button ### 📊 Changes **3 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/control_settings.cpp` (+8 -0) 📝 `src/qt_gui/hotkeys.cpp` (+6 -0) 📝 `src/qt_gui/kbm_gui.cpp` (+8 -0) </details> ### 📄 Description this prevents the GUI saving the string "press a button - [3]" that could be done when the save or apply buttons are pressed while the dialog is waiting for inputs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>