[PR #3478] [MERGED] shader_recompiler: Initialize all ClipDistance and CullDistance values #3500

New issue

Closed

opened 2026-02-27 22:03:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3478
Author: @StevenMiller123
Created: 8/29/2025
Status: ✅ Merged
Merged: 8/29/2025
Merged by: @squidbus

Base: main ← Head: export-fix-rdna3

📝 Commits (3)

57d980a Initialize all values in clip_distances
783fc2e Clang
48805ce Apply initializer for CullDistance

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+10 -4)

📄 Description

This PR fixes some graphical regressions on certain AMD and Intel GPUs after #3447

Before	After

Thanks to @squidbus for helping with debugging this, and @raphaelthegreat for helping with the solution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3478 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 8/29/2025 **Status:** ✅ Merged **Merged:** 8/29/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `export-fix-rdna3` --- ### 📝 Commits (3) - [`57d980a`](https://github.com/shadps4-emu/shadPS4/commit/57d980a5b74936b16168efdd527387cdc288d251) Initialize all values in clip_distances - [`783fc2e`](https://github.com/shadps4-emu/shadPS4/commit/783fc2e4866064268ac6fec82141d91554deaecc) Clang - [`48805ce`](https://github.com/shadps4-emu/shadPS4/commit/48805ce46be0959e57aa8513b52eab296bcc5d49) Apply initializer for CullDistance ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+10 -4) </details> ### 📄 Description This PR fixes some graphical regressions on certain AMD and Intel GPUs after #3447 | Before | After | |--------|-------| | <img width="1282" height="752" alt="image" src="https://github.com/user-attachments/assets/cc604d1f-ca7d-4f7d-b63d-752b087a3234" /> | <img width="1284" height="767" alt="image" src="https://github.com/user-attachments/assets/39ada999-a197-43fb-aeb9-85b43e6d23b0" /> | Thanks to @squidbus for helping with debugging this, and @raphaelthegreat for helping with the solution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>