[PR #3453] [MERGED] renderer_vulkan: Restore color write dynamic state #3478

New issue

Closed

opened 2026-02-27 22:03:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3453
Author: @raphaelthegreat
Created: 8/24/2025
Status: ✅ Merged
Merged: 8/24/2025
Merged by: @squidbus

Base: main ← Head: restore-dynamic

📝 Commits (1)

601c2bc renderer_vulkan: Resore color write dynamic state

📊 Changes

9 files changed (+61 additions, -6 deletions)

View changed files

📝 src/video_core/amdgpu/pixel_format.h (+8 -0)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+8 -1)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+5 -1)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+14 -0)
📝 src/video_core/renderer_vulkan/vk_instance.h (+8 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+2 -4)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+1 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+6 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+9 -0)

📄 Description

Should fix https://github.com/shadps4-emu/shadPS4/pull/3449#issuecomment-3217975161
It appears shader side discards break when color write masks are not dynamic on NVIDIA, I have no idea why but restore it for now

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3453 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 8/24/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `restore-dynamic` --- ### 📝 Commits (1) - [`601c2bc`](https://github.com/shadps4-emu/shadPS4/commit/601c2bc44ca5af2c8ae84caec0970203bbf6fb93) renderer_vulkan: Resore color write dynamic state ### 📊 Changes **9 files changed** (+61 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/amdgpu/pixel_format.h` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+8 -1) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+5 -1) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+14 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+8 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+2 -4) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+6 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+9 -0) </details> ### 📄 Description Should fix https://github.com/shadps4-emu/shadPS4/pull/3449#issuecomment-3217975161 It appears shader side discards break when color write masks are not dynamic on NVIDIA, I have no idea why but restore it for now --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>