[PR #3450] [MERGED] video_core: Fix some struct comparisons. #3477

New issue

Closed

opened 2026-02-27 22:03:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3450
Author: @squidbus
Created: 8/24/2025
Status: ✅ Merged
Merged: 8/24/2025
Merged by: @squidbus

Base: main ← Head: struct

📝 Commits (1)

15265bf video_core: Fix some struct comparisons.

📊 Changes

3 files changed (+22 additions, -13 deletions)

View changed files

📝 src/shader_recompiler/specialization.h (+4 -4)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+4 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+14 -9)

📄 Description

In specialization, replace some three-way comparison operator declarations with equality operators, as some of the contents are not three-way comparable.
For state structs that are compared using memcmp, initialize full struct (including padding) to zero in constructor.

Fixes some lag due to state being constantly deemed to be dirty.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3450 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 8/24/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `struct` --- ### 📝 Commits (1) - [`15265bf`](https://github.com/shadps4-emu/shadPS4/commit/15265bf82ff02c5367574ce7546762008d069f73) video_core: Fix some struct comparisons. ### 📊 Changes **3 files changed** (+22 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/specialization.h` (+4 -4) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+4 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+14 -9) </details> ### 📄 Description * In `specialization`, replace some three-way comparison operator declarations with equality operators, as some of the contents are not three-way comparable. * For state structs that are compared using `memcmp`, initialize full struct (including padding) to zero in constructor. Fixes some lag due to state being constantly deemed to be dirty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>