[PR #3355] [MERGED] controller select crash fix + minor changes #3411

New issue

Closed

opened 2026-02-27 22:03:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3355
Author: @rainmakerv3
Created: 7/30/2025
Status: ✅ Merged
Merged: 7/31/2025
Merged by: @georgemoralis

Base: main ← Head: gamepad-fixes

📝 Commits (3)

efa573b fix crash and ingame controller check
882ae95 performance issue fix
b946d3e add change controller event to imgui

📊 Changes

4 files changed (+45 additions, -43 deletions)

View changed files

📝 src/imgui/renderer/imgui_impl_sdl3.cpp (+10 -9)
📝 src/qt_gui/control_settings.cpp (+5 -6)
📝 src/qt_gui/control_settings.ui (+28 -28)
📝 src/qt_gui/sdl_event_wrapper.cpp (+2 -0)

📄 Description

Fixes constructor crash and imgui mistake causing some performance degradation

Also fixes detection of gamepad added/removed, and puts L1/R1 to the left or L2/R2 in the gui

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3355 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 7/30/2025 **Status:** ✅ Merged **Merged:** 7/31/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `gamepad-fixes` --- ### 📝 Commits (3) - [`efa573b`](https://github.com/shadps4-emu/shadPS4/commit/efa573b95685ecc923470a935b9f43d09b34858c) fix crash and ingame controller check - [`882ae95`](https://github.com/shadps4-emu/shadPS4/commit/882ae95fc30c8a703c02e83b550afe3bcb34fde6) performance issue fix - [`b946d3e`](https://github.com/shadps4-emu/shadPS4/commit/b946d3e0d4287a86e9b86cd616667d53ec408d68) add change controller event to imgui ### 📊 Changes **4 files changed** (+45 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `src/imgui/renderer/imgui_impl_sdl3.cpp` (+10 -9) 📝 `src/qt_gui/control_settings.cpp` (+5 -6) 📝 `src/qt_gui/control_settings.ui` (+28 -28) 📝 `src/qt_gui/sdl_event_wrapper.cpp` (+2 -0) </details> ### 📄 Description Fixes constructor crash and imgui mistake causing some performance degradation Also fixes detection of gamepad added/removed, and puts L1/R1 to the left or L2/R2 in the gui --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>