[PR #3305] [MERGED] qt: Add toggle in the settings window for readbacks #3375

New issue

Closed

opened 2026-02-27 22:03:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3305
Author: @tomboylover93
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @georgemoralis

Base: main ← Head: readbacks-gui-toggle

📝 Commits (8)

5127550 Add readback and readback linear image toggles to the settings window
e51975c fix
37af75e reuse and crowdin
ffb42cc clang-format... my worst enemy...
7a7cdd0 Merge branch 'shadps4-emu:main' into readbacks-gui-toggle
9b55e92 Merge branch 'main' into readbacks-gui-toggle
b7b79b2 Experimental group box (#3)
5039c1b revised warning on experimental group box

📊 Changes

5 files changed (+124 additions, -46 deletions)

View changed files

📝 src/common/config.cpp (+4 -0)
📝 src/common/config.h (+1 -0)
📝 src/qt_gui/settings_dialog.cpp (+11 -0)
📝 src/qt_gui/settings_dialog.ui (+92 -46)
📝 src/qt_gui/translations/en_US.ts (+16 -0)

📄 Description

See PR title.
Also adds a toggle for "Readback Linear Images".
Since the current readbacks implementation is slow and will most likely be rewritten in the future and adding a toggle in the Settings window for it has been a point of discussion, I thought to lock it behind another "Advanced" section to avoid people enabling it and coming across issues in games that don't need it/don't work well with it as a result, but I felt like it was beyond the scope of this PR (perhaps a warning about not enabling it unless being told to would suffice?). Let me know if you have any ideas.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3305 **Author:** [@tomboylover93](https://github.com/tomboylover93) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `readbacks-gui-toggle` --- ### 📝 Commits (8) - [`5127550`](https://github.com/shadps4-emu/shadPS4/commit/5127550185e0f24b2824064cd7d7bab2d4278b76) Add readback and readback linear image toggles to the settings window - [`e51975c`](https://github.com/shadps4-emu/shadPS4/commit/e51975c31ad9209b0ed635bd5bb2d265b0fb28dc) fix - [`37af75e`](https://github.com/shadps4-emu/shadPS4/commit/37af75ec95f378475f30a244d55533a753df1eb8) reuse and crowdin - [`ffb42cc`](https://github.com/shadps4-emu/shadPS4/commit/ffb42cc279e57c28ecaf1babb36876f4ab8085c3) clang-format... my worst enemy... - [`7a7cdd0`](https://github.com/shadps4-emu/shadPS4/commit/7a7cdd0f72e3589405a0d80f1358e71a0f7893d1) Merge branch 'shadps4-emu:main' into readbacks-gui-toggle - [`9b55e92`](https://github.com/shadps4-emu/shadPS4/commit/9b55e928575fd4bc7918e272e5d67556a2120aeb) Merge branch 'main' into readbacks-gui-toggle - [`b7b79b2`](https://github.com/shadps4-emu/shadPS4/commit/b7b79b24f493bcddd66772e81d82ce1d275a9b9b) Experimental group box (#3) - [`5039c1b`](https://github.com/shadps4-emu/shadPS4/commit/5039c1ba09afae52a8d5b85b2e05e1f2900ab4c1) revised warning on experimental group box ### 📊 Changes **5 files changed** (+124 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+4 -0) 📝 `src/common/config.h` (+1 -0) 📝 `src/qt_gui/settings_dialog.cpp` (+11 -0) 📝 `src/qt_gui/settings_dialog.ui` (+92 -46) 📝 `src/qt_gui/translations/en_US.ts` (+16 -0) </details> ### 📄 Description See PR title. Also adds a toggle for "Readback Linear Images". Since the current readbacks implementation is slow and will most likely be rewritten in the future and adding a toggle in the Settings window for it has been a point of discussion, I thought to lock it behind another "Advanced" section to avoid people enabling it and coming across issues in games that don't need it/don't work well with it as a result, but I felt like it was beyond the scope of this PR (perhaps a warning about not enabling it unless being told to would suffice?). Let me know if you have any ideas. <img width="964" height="744" alt="image" src="https://github.com/user-attachments/assets/72d1b49d-ea91-4de4-993d-d44bae24a045" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>