[PR #3225] [MERGED] shader_recompiler: Implement ff1 with subgroup ops #3318

New issue

Closed

opened 2026-02-27 22:03:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3225
Author: @raphaelthegreat
Created: 7/10/2025
Status: ✅ Merged
Merged: 7/10/2025
Merged by: @georgemoralis

Base: main ← Head: readlane2

📝 Commits (1)

aaf1da1 shader_recompiler: Implement ff1 with subgroup ops

📊 Changes

8 files changed (+27 additions, -14 deletions)

View changed files

📝 externals/sirit (+1 -1)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+2 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp (+8 -0)
📝 src/shader_recompiler/frontend/translate/scalar_alu.cpp (+3 -2)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+8 -0)
📝 src/shader_recompiler/ir/ir_emitter.h (+2 -0)
📝 src/shader_recompiler/ir/opcodes.inc (+2 -0)
📝 src/shader_recompiler/ir/passes/readlane_elimination_pass.cpp (+1 -11)

📄 Description

My other PR was snipe merged before I had a chance to present the alternate implementation :/ https://github.com/shadps4-emu/shadPS4/pull/3224#issuecomment-3056958483

This approach is more faithful to original source code and might work better if ff1 is used with conditions other than current exec. I don't know if it's better than the other one though

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3225 **Author:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Created:** 7/10/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `readlane2` --- ### 📝 Commits (1) - [`aaf1da1`](https://github.com/shadps4-emu/shadPS4/commit/aaf1da15a5023bf83bccce1d055227672063070f) shader_recompiler: Implement ff1 with subgroup ops ### 📊 Changes **8 files changed** (+27 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `externals/sirit` (+1 -1) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+2 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_warp.cpp` (+8 -0) 📝 `src/shader_recompiler/frontend/translate/scalar_alu.cpp` (+3 -2) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+8 -0) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+2 -0) 📝 `src/shader_recompiler/ir/opcodes.inc` (+2 -0) 📝 `src/shader_recompiler/ir/passes/readlane_elimination_pass.cpp` (+1 -11) </details> ### 📄 Description My other PR was snipe merged before I had a chance to present the alternate implementation :/ https://github.com/shadps4-emu/shadPS4/pull/3224#issuecomment-3056958483 This approach is more faithful to original source code and might work better if ff1 is used with conditions other than current exec. I don't know if it's better than the other one though --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>