[PR #3101] [CLOSED] Changed the order of defining the current code #3225

New issue

Closed

opened 2026-02-27 22:02:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3101
Author: @ivan999
Created: 6/16/2025
Status: ❌ Closed

Base: main ← Head: improve-recompiler-frontend-decode

📝 Commits (5)

2a1a104 Reduced amount of switch cases during instruction decoding
cee8814 Formatting has been changed to pass clang format checking
2d03dc7 The order of checking the codes was changed
8ec6a5d Merge branch 'shadps4-emu:main' into improve-recompiler-frontend-decode
29836c9 Merge branch 'shadps4-emu:main' into improve-recompiler-frontend-decode

📊 Changes

3 files changed (+155 additions, -277 deletions)

View changed files

📝 src/shader_recompiler/frontend/decode.cpp (+141 -251)
📝 src/shader_recompiler/frontend/decode.h (+14 -24)
📝 src/shader_recompiler/frontend/opcodes.h (+0 -2)

📄 Description

GcnDecodeContext private methods structure has been changed.
getEncodingLength, getOpMapOffset have been deleted.

GetInstructionEncoding function has been deleted.
Logic from this function has been put to a set of new private methods.

The main idea was to reduce repeating of the switch cases.

Small corrections have been added too:
32 bits encodings methods parameter has been changed in the header file to u32, to be the same as in the cpp file.
InstEncoding::ILLEGAL is not needed anymore, so it has been removed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3101 **Author:** [@ivan999](https://github.com/ivan999) **Created:** 6/16/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `improve-recompiler-frontend-decode` --- ### 📝 Commits (5) - [`2a1a104`](https://github.com/shadps4-emu/shadPS4/commit/2a1a1045ecb640af8c5f162ea3bb71fb67682142) Reduced amount of switch cases during instruction decoding - [`cee8814`](https://github.com/shadps4-emu/shadPS4/commit/cee8814be5cc69f3582bda365bde96df26fd277b) Formatting has been changed to pass clang format checking - [`2d03dc7`](https://github.com/shadps4-emu/shadPS4/commit/2d03dc75948cf15187d8a34668b28da6fd4a8f18) The order of checking the codes was changed - [`8ec6a5d`](https://github.com/shadps4-emu/shadPS4/commit/8ec6a5d1d44abeab5481f041d69814f79b45d3e2) Merge branch 'shadps4-emu:main' into improve-recompiler-frontend-decode - [`29836c9`](https://github.com/shadps4-emu/shadPS4/commit/29836c9d2ea4a21d60218ffa3badcf4b5633727a) Merge branch 'shadps4-emu:main' into improve-recompiler-frontend-decode ### 📊 Changes **3 files changed** (+155 additions, -277 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/decode.cpp` (+141 -251) 📝 `src/shader_recompiler/frontend/decode.h` (+14 -24) 📝 `src/shader_recompiler/frontend/opcodes.h` (+0 -2) </details> ### 📄 Description GcnDecodeContext private methods structure has been changed. getEncodingLength, getOpMapOffset have been deleted. GetInstructionEncoding function has been deleted. Logic from this function has been put to a set of new private methods. The main idea was to reduce repeating of the switch cases. Small corrections have been added too: 32 bits encodings methods parameter has been changed in the header file to u32, to be the same as in the cpp file. InstEncoding::ILLEGAL is not needed anymore, so it has been removed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>