[PR #3207] [MERGED] IME fixes #3306

New issue

Closed

opened 2026-02-27 22:03:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:03:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3207
Author: @w1naenator
Created: 7/7/2025
Status: ✅ Merged
Merged: 7/7/2025
Merged by: @georgemoralis

Base: main ← Head: ime-fixes

📝 Commits (2)

ee14241 IME fixes
0b81019 Merge branch 'main' into ime-fixes

📊 Changes

7 files changed (+325 additions, -258 deletions)

View changed files

📝 src/core/libraries/ime/ime.cpp (+34 -34)
📝 src/core/libraries/ime/ime.h (+7 -73)
📝 src/core/libraries/ime/ime_common.h (+228 -4)
📝 src/core/libraries/ime/ime_dialog.cpp (+29 -20)
📝 src/core/libraries/ime/ime_dialog.h (+0 -120)
📝 src/core/libraries/ime/ime_dialog_ui.cpp (+26 -6)
📝 src/core/libraries/ime/ime_ui.cpp (+1 -1)

📄 Description

Moved enums, flags, and structs to ime_common.h to simplify usage with Ime and ImeDialog
Updated Ime to use an enum as the return type, consistent with ImeDialog
Removed duplicate definition of OrbisImeKeycode
Added OrbisImeLanguage as a flags enum
Added missing options to OrbisImeOption
Removed OrbisImeDialogOption; OrbisImeOption should be used instead
Added OrbisImeTextAreaMode
Updated OrbisImeTextAreaProperty
Fixed OrbisImeEventParam by adding the missing member OrbisImePanelType panel_type
Updated the sceImeOpen declaration to use extended parameters (not yet implemented)
Fixed Diablo III (CUSA00434) assertion failure on ImeDialog initialization

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3207 **Author:** [@w1naenator](https://github.com/w1naenator) **Created:** 7/7/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ime-fixes` --- ### 📝 Commits (2) - [`ee14241`](https://github.com/shadps4-emu/shadPS4/commit/ee1424186e0be592a681f79859e468685389ed6a) IME fixes - [`0b81019`](https://github.com/shadps4-emu/shadPS4/commit/0b8101977c31eb490d78a41c4097ab7cbe81fbaa) Merge branch 'main' into ime-fixes ### 📊 Changes **7 files changed** (+325 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/ime/ime.cpp` (+34 -34) 📝 `src/core/libraries/ime/ime.h` (+7 -73) 📝 `src/core/libraries/ime/ime_common.h` (+228 -4) 📝 `src/core/libraries/ime/ime_dialog.cpp` (+29 -20) 📝 `src/core/libraries/ime/ime_dialog.h` (+0 -120) 📝 `src/core/libraries/ime/ime_dialog_ui.cpp` (+26 -6) 📝 `src/core/libraries/ime/ime_ui.cpp` (+1 -1) </details> ### 📄 Description - Moved enums, flags, and structs to ime_common.h to simplify usage with Ime and ImeDialog - Updated Ime to use an enum as the return type, consistent with ImeDialog - Removed duplicate definition of OrbisImeKeycode - Added OrbisImeLanguage as a flags enum - Added missing options to OrbisImeOption - Removed OrbisImeDialogOption; OrbisImeOption should be used instead - Added OrbisImeTextAreaMode - Updated OrbisImeTextAreaProperty - Fixed OrbisImeEventParam by adding the missing member OrbisImePanelType panel_type - Updated the sceImeOpen declaration to use extended parameters (not yet implemented) - Fixed Diablo III (CUSA00434) assertion failure on ImeDialog initialization --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>