[PR #3117] [MERGED] Potential MacOS Build Fix #3236

New issue

Closed

opened 2026-02-27 22:02:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/3117
Author: @nickci2002
Created: 6/18/2025
Status: ✅ Merged
Merged: 6/18/2025
Merged by: @kalaposfos13

Base: main ← Head: MacOS-Build-Fix

📝 Commits (3)

ccd1782 Potential MacOS build fix for update
0e73cda Merge remote-tracking branch 'origin/MacOS-Build-Fix' into MacOS-Build-Fix
4a810b8 Imported string instead of changing name to std::string_view

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/core/memory.h (+1 -0)

📄 Description

Changed std::string to std::string_view after new update broke the MacOS build.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/3117 **Author:** [@nickci2002](https://github.com/nickci2002) **Created:** 6/18/2025 **Status:** ✅ Merged **Merged:** 6/18/2025 **Merged by:** [@kalaposfos13](https://github.com/kalaposfos13) **Base:** `main` ← **Head:** `MacOS-Build-Fix` --- ### 📝 Commits (3) - [`ccd1782`](https://github.com/shadps4-emu/shadPS4/commit/ccd1782631ca29fda512b2a2e14af4004fe0795d) Potential MacOS build fix for update - [`0e73cda`](https://github.com/shadps4-emu/shadPS4/commit/0e73cdaaf79e1e6fa8eb384cdd20a801cbe10ff4) Merge remote-tracking branch 'origin/MacOS-Build-Fix' into MacOS-Build-Fix - [`4a810b8`](https://github.com/shadps4-emu/shadPS4/commit/4a810b826ce55b1256d72caef38cc03cb4566dbc) Imported string instead of changing name to std::string_view ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/core/memory.h` (+1 -0) </details> ### 📄 Description Changed std::string to std::string_view after new update broke the MacOS build. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>