[PR #2973] [MERGED] shader_recompiler: Fix buffer type reading from step rate attribute. #3117

New issue

Closed

opened 2026-02-27 22:02:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2973
Author: @squidbus
Created: 5/22/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @squidbus

Base: main ← Head: fix-step-rate-read

📝 Commits (1)

7c2ad45 shader_recompiler: Fix buffer type reading from step rate attribute.

📊 Changes

1 file changed (+12 additions, -7 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+12 -7)

📄 Description

EmitReadConstBuffer is reading as U32 when we need F32 for this case, causing a crash since the buffer is not defined with the U32 alias. Fix by separating out a template function which can vary the alias.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2973 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 5/22/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `fix-step-rate-read` --- ### 📝 Commits (1) - [`7c2ad45`](https://github.com/shadps4-emu/shadPS4/commit/7c2ad450108569f4b40cd15ca8ed6062f60d9969) shader_recompiler: Fix buffer type reading from step rate attribute. ### 📊 Changes **1 file changed** (+12 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+12 -7) </details> ### 📄 Description `EmitReadConstBuffer` is reading as `U32` when we need `F32` for this case, causing a crash since the buffer is not defined with the `U32` alias. Fix by separating out a template function which can vary the alias. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>