[PR #2971] [MERGED] savedata: Fix missing uses of config based save data dir. #3118

New issue

Closed

opened 2026-02-27 22:02:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2971
Author: @squidbus
Created: 5/22/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @georgemoralis

Base: main ← Head: save-dir-fix

📝 Commits (1)

ad2a5f4 savedata: Fix missing uses of config based save data dir.

📊 Changes

5 files changed (+7 additions, -12 deletions)

View changed files

📝 src/common/config.cpp (+1 -1)
📝 src/common/path_util.cpp (+0 -1)
📝 src/common/path_util.h (+0 -2)
📝 src/core/libraries/save_data/savedata.cpp (+2 -1)
📝 src/qt_gui/gui_context_menus.h (+4 -7)

📄 Description

Fix a few places that were using the default save data directory path instead of the one specified by config.
Fix Qt GUI delete still using game serial instead of correct save data directory name.
Remove PathType::SaveDataDir so it won't be mistakenly use; instead just do same as DLC directory and have the default in the config function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2971 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 5/22/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `save-dir-fix` --- ### 📝 Commits (1) - [`ad2a5f4`](https://github.com/shadps4-emu/shadPS4/commit/ad2a5f45d6636c72707bad1c0fc96a0be2cd84e9) savedata: Fix missing uses of config based save data dir. ### 📊 Changes **5 files changed** (+7 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+1 -1) 📝 `src/common/path_util.cpp` (+0 -1) 📝 `src/common/path_util.h` (+0 -2) 📝 `src/core/libraries/save_data/savedata.cpp` (+2 -1) 📝 `src/qt_gui/gui_context_menus.h` (+4 -7) </details> ### 📄 Description * Fix a few places that were using the default save data directory path instead of the one specified by config. * Fix Qt GUI delete still using game serial instead of correct save data directory name. * Remove `PathType::SaveDataDir` so it won't be mistakenly use; instead just do same as DLC directory and have the default in the config function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>