[PR #2886] [MERGED] shader_recompiler: Widen num_conversion bitfield #3054

New issue

Closed

opened 2026-02-27 22:02:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2886
Author: @MajorP93
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/7/2025
Merged by: @squidbus

Base: main ← Head: num_conversion

📝 Commits (1)

a424f3f shader_recompiler: Widen num_conversion bitfield

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/shader_recompiler/runtime_info.h (+2 -2)

📄 Description

We do this in order to be able to actually fit in all possible values from AmdGpu::NumberConversion.

Fixes gcc compiler warnings:
warning: ‘Shader::PsColorBuffer::num_conversion’ is too small to hold all values of ‘enum class AmdGpu::NumberConversion’

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2886 **Author:** [@MajorP93](https://github.com/MajorP93) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/7/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `num_conversion` --- ### 📝 Commits (1) - [`a424f3f`](https://github.com/shadps4-emu/shadPS4/commit/a424f3f570a63a5987b893f41145a7970b1758b3) shader_recompiler: Widen num_conversion bitfield ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/runtime_info.h` (+2 -2) </details> ### 📄 Description We do this in order to be able to actually fit in all possible values from AmdGpu::NumberConversion. Fixes gcc compiler warnings: warning: ‘Shader::PsColorBuffer::num_conversion’ is too small to hold all values of ‘enum class AmdGpu::NumberConversion’ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>