[PR #2854] [MERGED] Code Review: SuspiciousPriority #3030

New issue

Closed

opened 2026-02-27 22:02:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2854
Author: @ljhcage
Created: 4/27/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @squidbus

Base: main ← Head: main

📝 Commits (1)

6d5af3f Code Review: SuspiciousPriority

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 src/common/memory_patcher.cpp (+2 -1)
📝 src/qt_gui/cheats_patches.cpp (+1 -1)

📄 Description

Priority of the '&&' operation is higher than that of the '||' operation.It's possible that parentheses should be used in the expression.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2854 **Author:** [@ljhcage](https://github.com/ljhcage) **Created:** 4/27/2025 **Status:** ✅ Merged **Merged:** 4/28/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`6d5af3f`](https://github.com/shadps4-emu/shadPS4/commit/6d5af3f88e1efed56588178cab37b697313315a2) Code Review: SuspiciousPriority ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/common/memory_patcher.cpp` (+2 -1) 📝 `src/qt_gui/cheats_patches.cpp` (+1 -1) </details> ### 📄 Description Priority of the '&&' operation is higher than that of the '||' operation.It's possible that parentheses should be used in the expression. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>