[PR #2600] [CLOSED] Remove Unused Semicolons, Fix Windows.h includes and Minor Warnings Fixes #2854

New issue

Closed

opened 2026-02-27 22:01:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2600
Author: @Xphalnos
Created: 3/5/2025
Status: ❌ Closed

Base: main ← Head: Remove_Semicolons

📝 Commits (1)

b6e212a Remove Unused Semicolons, Fix Windows.h includes and Minor Warnings Fixes

📊 Changes

65 files changed (+74 additions, -77 deletions)

View changed files

📝 src/common/config.h (+1 -1)
📝 src/common/error.cpp (+1 -1)
📝 src/common/hash.h (+1 -1)
📝 src/common/io_file.cpp (+1 -1)
📝 src/common/logging/backend.cpp (+1 -1)
📝 src/common/logging/formatter.h (+1 -1)
📝 src/common/logging/text_formatter.cpp (+1 -1)
📝 src/common/memory_patcher.h (+1 -1)
📝 src/common/ntapi.h (+1 -1)
📝 src/common/number_utils.cpp (+1 -1)
📝 src/common/path_util.cpp (+2 -2)
📝 src/common/rdtsc.cpp (+1 -1)
📝 src/common/signal_context.cpp (+2 -2)
📝 src/common/signal_context.h (+1 -1)
📝 src/common/string_util.cpp (+1 -1)
📝 src/common/thread.cpp (+1 -1)
📝 src/core/address_space.cpp (+1 -1)
📝 src/core/cpu_patches.cpp (+1 -1)
📝 src/core/crypto/keys.h (+1 -1)
📝 src/core/file_format/trp.h (+1 -1)

...and 45 more files

📄 Description

I used warning level 4 for Clang to find the warnings

Remove unused semicolons
Changed includes from windows.h to Windows.h as this creates a warning
Minor Warnings Fixes
Adding spaces below files that don't have them (Another clang warning)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2600 **Author:** [@Xphalnos](https://github.com/Xphalnos) **Created:** 3/5/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Remove_Semicolons` --- ### 📝 Commits (1) - [`b6e212a`](https://github.com/shadps4-emu/shadPS4/commit/b6e212a3783edabcf47bb50c13d1419ccbb90b7f) Remove Unused Semicolons, Fix Windows.h includes and Minor Warnings Fixes ### 📊 Changes **65 files changed** (+74 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.h` (+1 -1) 📝 `src/common/error.cpp` (+1 -1) 📝 `src/common/hash.h` (+1 -1) 📝 `src/common/io_file.cpp` (+1 -1) 📝 `src/common/logging/backend.cpp` (+1 -1) 📝 `src/common/logging/formatter.h` (+1 -1) 📝 `src/common/logging/text_formatter.cpp` (+1 -1) 📝 `src/common/memory_patcher.h` (+1 -1) 📝 `src/common/ntapi.h` (+1 -1) 📝 `src/common/number_utils.cpp` (+1 -1) 📝 `src/common/path_util.cpp` (+2 -2) 📝 `src/common/rdtsc.cpp` (+1 -1) 📝 `src/common/signal_context.cpp` (+2 -2) 📝 `src/common/signal_context.h` (+1 -1) 📝 `src/common/string_util.cpp` (+1 -1) 📝 `src/common/thread.cpp` (+1 -1) 📝 `src/core/address_space.cpp` (+1 -1) 📝 `src/core/cpu_patches.cpp` (+1 -1) 📝 `src/core/crypto/keys.h` (+1 -1) 📝 `src/core/file_format/trp.h` (+1 -1) _...and 45 more files_ </details> ### 📄 Description I used warning level 4 for Clang to find the warnings - Remove unused semicolons - Changed includes from `windows.h` to `Windows.h` as this creates a warning - Minor Warnings Fixes - Adding spaces below files that don't have them (Another clang warning) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>