[PR #2841] [MERGED] Unpack SnormNz 2x16 #3020

New issue

Closed

opened 2026-02-27 22:02:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:02:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2841
Author: @AboMedoz
Created: 4/24/2025
Status: ✅ Merged
Merged: 5/1/2025
Merged by: @squidbus

Base: main ← Head: unpack-snorm2x16

📝 Commits (10+)

c373e38 +
31bd2c6 +
cee375f Unpack Snorm 2x16
1627bcc +
9a9aa24 Merge branch 'shadps4-emu:main' into unpack-snorm2x16
ba36139 SintToSnormNz
9e60665 all is broken ig....
62a5f13 review changes
c68c02b +
0bbc095 Merge branch 'unpack-snorm2x16' of https://github.com/AboMedoz/shadPS4 into unpack-snorm2x16

📊 Changes

6 files changed (+50 additions, -6 deletions)

View changed files

📝 CMakeLists.txt (+0 -0)
📝 src/shader_recompiler/ir/passes/lower_buffer_format_to_raw.cpp (+2 -1)
📝 src/shader_recompiler/ir/reinterpret.h (+26 -0)
📝 src/video_core/amdgpu/liverpool.h (+1 -1)
📝 src/video_core/amdgpu/resource.h (+2 -2)
📝 src/video_core/amdgpu/types.h (+19 -2)

📄 Description

My poor attempt to implement this case but i think there is a Problem with it but it should solve the error in InFAMOUS

[Debug] <Critical> ir_emitter.cpp:866 Unpack2x16: Unreachable code!
Unsupported 2x16 number format: SnormNz

this case is responsible for face textures as i noticed

PR :

SnormNz stubbed with Snorm :

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2841 **Author:** [@AboMedoz](https://github.com/AboMedoz) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 5/1/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `unpack-snorm2x16` --- ### 📝 Commits (10+) - [`c373e38`](https://github.com/shadps4-emu/shadPS4/commit/c373e385d029f35e0064fe612e9bcaa857138138) + - [`31bd2c6`](https://github.com/shadps4-emu/shadPS4/commit/31bd2c639de773b34ca8a292468653189f7861aa) + - [`cee375f`](https://github.com/shadps4-emu/shadPS4/commit/cee375fd3e02fa509e3b9454c25a88fb5ded5e75) Unpack Snorm 2x16 - [`1627bcc`](https://github.com/shadps4-emu/shadPS4/commit/1627bcc575406d73ed16f4fb8d6fc1abc8c6a969) + - [`9a9aa24`](https://github.com/shadps4-emu/shadPS4/commit/9a9aa24756808c7fdaf499fdbc2147f41fbed546) Merge branch 'shadps4-emu:main' into unpack-snorm2x16 - [`ba36139`](https://github.com/shadps4-emu/shadPS4/commit/ba36139bc7a015d23da67d947f62db928ee32dba) SintToSnormNz - [`9e60665`](https://github.com/shadps4-emu/shadPS4/commit/9e60665c7381ad66de06aa67053c09b21471c41a) all is broken ig.... - [`62a5f13`](https://github.com/shadps4-emu/shadPS4/commit/62a5f132c383ab0acc932661a4d8b37d99529c9c) review changes - [`c68c02b`](https://github.com/shadps4-emu/shadPS4/commit/c68c02baa32b10b07cba89c693bf16ff5ab3896b) + - [`0bbc095`](https://github.com/shadps4-emu/shadPS4/commit/0bbc095cd1ee881a55e61a7c1db598cd2abf388d) Merge branch 'unpack-snorm2x16' of https://github.com/AboMedoz/shadPS4 into unpack-snorm2x16 ### 📊 Changes **6 files changed** (+50 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+0 -0) 📝 `src/shader_recompiler/ir/passes/lower_buffer_format_to_raw.cpp` (+2 -1) 📝 `src/shader_recompiler/ir/reinterpret.h` (+26 -0) 📝 `src/video_core/amdgpu/liverpool.h` (+1 -1) 📝 `src/video_core/amdgpu/resource.h` (+2 -2) 📝 `src/video_core/amdgpu/types.h` (+19 -2) </details> ### 📄 Description My poor attempt to implement this case but i think there is a Problem with it but it should solve the error in InFAMOUS ``` [Debug] <Critical> ir_emitter.cpp:866 Unpack2x16: Unreachable code! Unsupported 2x16 number format: SnormNz ``` this case is responsible for face textures as i noticed ### PR : ![image](https://github.com/user-attachments/assets/8b9db70d-5c0c-43f6-9e85-19c235d4239f) ### SnormNz stubbed with Snorm : ![image](https://github.com/user-attachments/assets/2be838aa-a12a-4ef9-a04a-edc29768ef25) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>