[PR #2764] [MERGED] renderer_vulkan: Make some primitive state dynamic. #2963

New issue

Closed

opened 2026-02-27 22:01:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2764
Author: @squidbus
Created: 4/9/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @squidbus

Base: main ← Head: prim-dyn-state

📝 Commits (2)

1c72fa8 renderer_vulkan: Make some primitive state dynamic.
0d3b0f9 renderer_vulkan: Silence MoltenVK primitive restart warning spam.

📊 Changes

10 files changed (+105 additions, -37 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+12 -0)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+2 -0)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+22 -19)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+0 -14)
📝 src/video_core/renderer_vulkan/vk_instance.h (+5 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+0 -4)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+20 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.cpp (+14 -0)
📝 src/video_core/renderer_vulkan/vk_scheduler.h (+29 -0)

📄 Description

Adds some more dynamic state usage, this time for some primitive state:

Primitive restart enabled
Cull mode
Front face

Primitive type is technically available but more complicated since, without an optional feature from VK_EXT_extended_dynamic_state3, you can't change between primitive types of different topology classes from the pipeline. Thus it remains as pipeline state at least for now.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2764 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `prim-dyn-state` --- ### 📝 Commits (2) - [`1c72fa8`](https://github.com/shadps4-emu/shadPS4/commit/1c72fa871fbc0c02f7bd6eb6c994009e6d071d91) renderer_vulkan: Make some primitive state dynamic. - [`0d3b0f9`](https://github.com/shadps4-emu/shadPS4/commit/0d3b0f9efc5d7826e2485021696179218914c2c4) renderer_vulkan: Silence MoltenVK primitive restart warning spam. ### 📊 Changes **10 files changed** (+105 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+12 -0) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+2 -0) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+22 -19) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+0 -14) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+5 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+0 -4) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+20 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.cpp` (+14 -0) 📝 `src/video_core/renderer_vulkan/vk_scheduler.h` (+29 -0) </details> ### 📄 Description Adds some more dynamic state usage, this time for some primitive state: * Primitive restart enabled * Cull mode * Front face Primitive type is technically available but more complicated since, without an optional feature from `VK_EXT_extended_dynamic_state3`, you can't change between primitive types of different topology classes from the pipeline. Thus it remains as pipeline state at least for now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>