[PR #2698] [MERGED] Change logtype from async to sync #2920

New issue

Closed

opened 2026-02-27 22:01:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2698
Author: @Missake212
Created: 3/27/2025
Status: ✅ Merged
Merged: 3/27/2025
Merged by: @georgemoralis

Base: main ← Head: async-to-sync

📝 Commits (1)

508e13a change async to sync

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/common/config.cpp (+2 -2)

📄 Description

This has been asked multiple times in the Discord server but no clear answer as to why the logtype should be kept to async was given, so I thought I'd make a PR in order to make sure it's finally discussed 😄.
Tested on a brand new PC and the log was set to sync so I guess I didn't miss anything (let me know if I did).
I don't think the performance cost of sync is that much of a problem, and it's easier for troubleshooting, I think it's best to keep it this way until the emulator is stable enough where troubleshooting won't be as common, but do let me know if you think this is not a good idea.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2698 **Author:** [@Missake212](https://github.com/Missake212) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 3/27/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `async-to-sync` --- ### 📝 Commits (1) - [`508e13a`](https://github.com/shadps4-emu/shadPS4/commit/508e13a8035fa05804296d8761f2cd2a772697f0) change async to sync ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/common/config.cpp` (+2 -2) </details> ### 📄 Description This has been asked multiple times in the Discord server but no clear answer as to why the logtype should be kept to async was given, so I thought I'd make a PR in order to make sure it's finally discussed 😄. Tested on a brand new PC and the log was set to sync so I guess I didn't miss anything (let me know if I did). I don't think the performance cost of sync is that much of a problem, and it's easier for troubleshooting, I think it's best to keep it this way until the emulator is stable enough where troubleshooting won't be as common, but do let me know if you think this is not a good idea. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>