[PR #2393] [MERGED] Add error message when trophy data extraction fails #2698

New issue

Closed

opened 2026-02-27 22:00:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2393
Author: @rainmakerv3
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/12/2025
Merged by: @georgemoralis

Base: main ← Head: TrophyKeyError

📝 Commits (1)

5f1dbdc Add error message when trophy data extraction fails

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 src/qt_gui/trophy_viewer.cpp (+7 -1)

📄 Description

When the trophy viewer is used without a trophy key, shadPS4 currently just opens an empty dialog without any error message, which is probably going to be confusing to those who do not know about trophy keys.

This PR adds an error after trp.extract fails (which outside of probably extremely rate filesystem errors will be due to lack of trophy key) and closes the dialog after failed extraction.

Translations not included

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2393 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/12/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `TrophyKeyError` --- ### 📝 Commits (1) - [`5f1dbdc`](https://github.com/shadps4-emu/shadPS4/commit/5f1dbdc99150f0cb99df78bec8ff8dbc3e15fdca) Add error message when trophy data extraction fails ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/trophy_viewer.cpp` (+7 -1) </details> ### 📄 Description When the trophy viewer is used without a trophy key, shadPS4 currently just opens an empty dialog without any error message, which is probably going to be confusing to those who do not know about trophy keys. ![2](https://github.com/user-attachments/assets/6aa0ba69-5c35-4f89-ad5d-5a65640e2fc2) This PR adds an error after trp.extract fails (which outside of probably extremely rate filesystem errors will be due to lack of trophy key) and closes the dialog after failed extraction. ![1](https://github.com/user-attachments/assets/7677d63f-03ce-4c8a-9963-1ff35cfc5b63) Translations not included --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>