[PR #2611] [CLOSED] Videodec2 mismatching picture info size crash fix #2860

New issue

Closed

opened 2026-02-27 22:01:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2611
Author: @Hasster1
Created: 3/6/2025
Status: ❌ Closed

Base: main ← Head: videodec2Log

📝 Commits (4)

f1fddbc Add a log message when GetPictureInfo has mismatching sizes of pictures.
79cd5e6 Add a log message when GetPictureInfo has mismatching sizes of pictures.
5bc6a02 Move "*picInfo" = gPictureInfos.Back()" before the return
ede9082 Fix submodules, accidentally somehow updated them.

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 src/core/libraries/videodec/videodec2.cpp (+6 -1)

📄 Description

Returning before setting *picInfo causes the emu to crash. I think it's better to let it deal with whatever corrupted size it is, rather than forcing the emu to crash.
Also added logging.

Closes the https://github.com/shadps4-emu/shadPS4/issues/2604

First pull request here, please correct me if something's wrong.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2611 **Author:** [@Hasster1](https://github.com/Hasster1) **Created:** 3/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `videodec2Log` --- ### 📝 Commits (4) - [`f1fddbc`](https://github.com/shadps4-emu/shadPS4/commit/f1fddbc8294dc18fe303127743a9e2addc806aa8) Add a log message when GetPictureInfo has mismatching sizes of pictures. - [`79cd5e6`](https://github.com/shadps4-emu/shadPS4/commit/79cd5e69a22229a489af115f0c811d548b72cc7a) Add a log message when GetPictureInfo has mismatching sizes of pictures. - [`5bc6a02`](https://github.com/shadps4-emu/shadPS4/commit/5bc6a027afbbba50e620bb70e756dd6f830323c8) Move "*picInfo" = gPictureInfos.Back()" before the return - [`ede9082`](https://github.com/shadps4-emu/shadPS4/commit/ede90821052e2fa9aa56714bc9898bf5275adc6c) Fix submodules, accidentally somehow updated them. ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/videodec/videodec2.cpp` (+6 -1) </details> ### 📄 Description Returning before setting *picInfo causes the emu to crash. I think it's better to let it deal with whatever corrupted size it is, rather than forcing the emu to crash. Also added logging. Closes the https://github.com/shadps4-emu/shadPS4/issues/2604 First pull request here, please correct me if something's wrong. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>